Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/195/#review447 --- Ship it! we might need to make this configurable due to processing and

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/195/ --- (Updated 2009-03-06 12:09:15.235406) Review request for Plasma. Changes ---

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-03 Thread Dominik Haumann
On Tuesday 03 March 2009, Aaron J. Seigo wrote: > On Monday 02 March 2009, Dominik Haumann wrote: > > @Crossfade effect: maybe also the type of the easein/out, but that's > > probably already included in the "timeelapse" parameter. > > what would be the use case for ease in vs ease out? (not that i

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-02 Thread Matthew Dawson
Hey, On Monday 02 March 2009 15:06:35 Aaron J. Seigo wrote: > comments on patch (besides "thanks! always great to receive patches from new > faces"): Thanks for the comments! > > - coding style. {s for methods start on their own line (see updateFadedImage) > and there is a space between the k

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-02 Thread Aaron J. Seigo
On Monday 02 March 2009, Dominik Haumann wrote: > @Crossfade effect: maybe also the type of the easein/out, but that's > probably already included in the "timeelapse" parameter. what would be the use case for ease in vs ease out? (not that it's not a valid idea, just wanting to get some more info

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-02 Thread Dominik Haumann
[...] > > Also the PictureFrame plasmoid comes to my mind here. A fade effect > > would be very nice as well and is the same code. Can it be shared > > somehow? > > this sort of thing really belongs in Animator or its successor; this > needs to become a set of standardized effects that we can imple

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-02 Thread Aaron J. Seigo
On Thursday 26 February 2009, Matthew Dawson wrote: > Unfortunately, reviewboard is not accepting this updated diff, so I'm > posting it here. I'm not sure why I thought it didn't work with single > images, but it does now. It also works in the configuration dialog box :). comments on patch (bes

Re: Review Request: Add fade effect to wallpaper plugin.

2009-03-02 Thread Aaron J. Seigo
On Friday 27 February 2009, Dominik Haumann wrote: > On Thursday 26 February 2009, Artur de Souza (MoRpHeUz) wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/195/#review287 > > ---

Re: Review Request: Add fade effect to wallpaper plugin.

2009-02-27 Thread Dominik Haumann
On Thursday 26 February 2009, Artur de Souza (MoRpHeUz) wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/195/#review287 > --- > >

Re: Review Request: Add fade effect to wallpaper plugin.

2009-02-26 Thread Matthew Dawson
Hello, Unfortunately, reviewboard is not accepting this updated diff, so I'm posting it here. I'm not sure why I thought it didn't work with single images, but it does now. It also works in the configuration dialog box :). Matthew On Thursday 26 February 2009 16:02:31 Artur de Souza (MoRpHeU

Re: Review Request: Add fade effect to wallpaper plugin.

2009-02-26 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/195/#review287 --- Hmm...the idea is pretty nice. Why it doesn't work for single images wal