Re: General applet test-case: Color change

2008-12-30 Thread Sebastian Kügler
On Sunday 28 December 2008 17:59:08 Jamboarder wrote: > > From: Sebastian Kügler > The test-case were for color changes only, not just theme changes (which is > also a good test case).  The test case can only be performed with the Aya > theme at the moment since it is the only plasma them which re

Re: General applet test-case: Color change

2008-12-30 Thread Marco Martin
On Monday 29 December 2008, Aaron J. Seigo wrote: > On Monday 29 December 2008, k...@randomguy3.me.uk wrote: > > On Sat, 27 Dec 2008 12:03:27 -0800 (PST), Jamboarder > > > > > > wrote: > > > The only remaining issues I could find > > > is that for a small number of applets, text colors aren't upda

Re: General applet test-case: Color change

2008-12-29 Thread Aaron J. Seigo
On Sunday 28 December 2008, Jamboarder wrote: > Yay. That leaves Kickoff " and " and "Search" text (missed > that one) fixed in r903072. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software s

Re: General applet test-case: Color change

2008-12-29 Thread Aaron J. Seigo
On Monday 29 December 2008, k...@randomguy3.me.uk wrote: > On Sat, 27 Dec 2008 12:03:27 -0800 (PST), Jamboarder > > wrote: > > The only remaining issues I could find > > is that for a small number of applets, text colors aren't updating till a > > plasma restart (or maybe an applet config update):

Re: General applet test-case: Color change

2008-12-29 Thread kde
On Sat, 27 Dec 2008 12:03:27 -0800 (PST), Jamboarder wrote: > The only remaining issues I could find > is that for a small number of applets, text colors aren't updating till a > plasma restart (or maybe an applet config update): > - Now Playing It wasn't working, I checked in the Plasma::Label

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
--- On Sun, 12/28/08, Jamboarder wrote: > ... That leaves Kickoff " and > " and "Search" text (missed that > one) as well as System Monitor (my latest svn rev - > r902603). I tell a lie: System Monitor works just fine (forgot to restart) :-). Andrew ___

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
--- On Sun, 12/28/08, Marco Martin wrote: > On Sunday 28 December 2008, Jamboarder wrote: > > --- On Sun, 12/28/08, Marco Martin > wrote: > > Quick, simple fix to emit the themeChanged signal > after the plasma color > > scheme update has been committed. This fixes all the > problems I listed in

Re: General applet test-case: Color change

2008-12-28 Thread Aaron J. Seigo
On Sunday 28 December 2008, Petri Damstén wrote: > On Sunday 28 December 2008 19:14:45 Jamboarder wrote: > > Try testing this as well: > > - Select Aya theme (use latest version if possible) > > - Change color from System Settings > Colors > > - check applets to make sure colors are correctly updat

Re: General applet test-case: Color change

2008-12-28 Thread Marco Martin
On Sunday 28 December 2008, Jamboarder wrote: > --- On Sun, 12/28/08, Marco Martin wrote: > > yes, in themes without a colors file the > > kdisplayPaletteChanged() signal is > > connected to themeChanged() signal, so is the only one > > needed > > Just noticed that themeChanged() was being emitted

Re: General applet test-case: Color change

2008-12-28 Thread Petri Damstén
On Sunday 28 December 2008 19:14:45 Jamboarder wrote: > Try testing this as well: > - Select Aya theme (use latest version if possible) > - Change color from System Settings > Colors > - check applets to make sure colors are correctly updated. > > The above was the test case the original report was

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
--- On Sun, 12/28/08, Marco Martin wrote: > yes, in themes without a colors file the > kdisplayPaletteChanged() signal is > connected to themeChanged() signal, so is the only one > needed Just noticed that themeChanged() was being emitted at the same time the Plasma color scheme was being updat

Re: General applet test-case: Color change

2008-12-28 Thread Marco Martin
On Sunday 28 December 2008, Jamboarder wrote: > --- On Sun, 12/28/08, Sebastian Kügler wrote: > > On Sunday 28 December 2008 17:59:08 Jamboarder wrote: > > > Sorry I should have been more clear. > > > > > > The test-case were for color changes only, not just > > > > theme changes (which is > > > >

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
--- On Sun, 12/28/08, Sebastian Kügler wrote: > On Sunday 28 December 2008 17:59:08 Jamboarder wrote: > > > > Sorry I should have been more clear. > > > > The test-case were for color changes only, not just > theme changes (which is > > also a good test case). The test case can only be > perfor

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
> From: Petri Damstén > On Sunday 28 December 2008 13:28:49 Marco Martin wrote: > > > > - System Monitor: graphs > > > > > > Currently hard coded. Not sure where to get good > colors for these? > > > > plasma background and text color, with ad added quite > hight amount of > > alpha? > > cpu & te

Re: General applet test-case: Color change

2008-12-28 Thread Sebastian Kügler
On Sunday 28 December 2008 17:59:08 Jamboarder wrote: > > Hm, what problems did you encounter? I've checked with > > the Air theme (dark on > > light instead of light on dark to make it well-visible) and > > all colours seem > > to be updated correctly on the fly ...) > > Sorry I should have been m

Re: General applet test-case: Color change

2008-12-28 Thread Jamboarder
> From: Sebastian Kügler > On Sunday 28 December 2008 16:42:44 Sebastian Kügler wrote: > > On Saturday 27 December 2008 21:03:27 Jamboarder > wrote: > > > Just thought I'd mention that I've been > testing how applets response to > > > color change to shake out any remaining bugs with > color chang

Re: General applet test-case: Color change

2008-12-28 Thread Sebastian Kügler
On Sunday 28 December 2008 16:42:44 Sebastian Kügler wrote: > On Saturday 27 December 2008 21:03:27 Jamboarder wrote: > > Just thought I'd mention that I've been testing how applets response to > > color change to shake out any remaining bugs with color changes and most > > applets appear to workin

Re: General applet test-case: Color change

2008-12-28 Thread Petri Damstén
On Sunday 28 December 2008 13:28:49 Marco Martin wrote: > > > - System Monitor: graphs > > > > Currently hard coded. Not sure where to get good colors for these? > > plasma background and text color, with ad added quite hight amount of > alpha? cpu & temp use now text color for graph (They were us

Re: General applet test-case: Color change

2008-12-28 Thread Sebastian Kügler
On Saturday 27 December 2008 21:03:27 Jamboarder wrote: > Just thought I'd mention that I've been testing how applets response to > color change to shake out any remaining bugs with color changes and most > applets appear to working fine.  Generally all svgs are updating correctly > and the majorit

Re: General applet test-case: Color change

2008-12-28 Thread Marco Martin
On Sunday 28 December 2008, Petri Damstén wrote: > On Saturday 27 December 2008 22:03:27 Jamboarder wrote: > > - News > > News changes colors on my setup. (By the way, desktop theme can use it own > stylesheet by providing THEME/stylesheets/news.css) > > > - Paste: same as Device Notifier > > Deskt

Re: General applet test-case: Color change

2008-12-28 Thread Ivan Čukić
> P.S. I'll mostly be working on the final artwork tidy ups for Aya till the > artwork freeze, so less time for code fixes (hence this email). Just to be clear, the artwork freeze doesn't mean you shouldn't make changes to existing artwork, but that you shouldn't add new artwork, so you can do the

Re: General applet test-case: Color change

2008-12-28 Thread Petri Damstén
On Saturday 27 December 2008 22:03:27 Jamboarder wrote: > - News News changes colors on my setup. (By the way, desktop theme can use it own stylesheet by providing THEME/stylesheets/news.css) > - Paste: same as Device Notifier Desktop/popup widget is created from the ui file and label color is