Re: RFC: Using `-Wno-unused-parameter` in Plasma projects

2021-10-27 Thread Aleix Pol
I agree that the status quo isn't ideal. Q_UNUSED() adds too much relevance to the argument that happens to be not needed. I think that the best most usable way is your b) where you comment out the arguments. I think the warning should be kept. The problem with c) is that we pollute the namespace

Re: RFC: Using `-Wno-unused-parameter` in Plasma projects

2021-10-27 Thread Vlad Zahorodnii
On 10/27/21 20:41, Vlad Zahorodnii wrote: Besides adding more work and code, it's easy to forget to remove Q_UNUSED() once it actually becomes readable used*

RFC: Using `-Wno-unused-parameter` in Plasma projects

2021-10-27 Thread Vlad Zahorodnii
Hi, The main issue with -Wunused-parameter is that it makes development more painful. For example, say that you have an observer class and you need to override a dozen of methods to handle various events, but you don't really care about arguments... In every method, you would need to add Q_UN