On Wednesday 27 May 2009 18:39:14 Richard Dale wrote:
> As well as your patch don't we need a 'do nothing' default
> implemtation of configChanged()?
Yes, that's true. Committed patch with this addition.
Petri
signature.asc
Description: This is a digitally signed message part.
On Wed, May 27, 2009 at 2:55 PM, Petri Damstén wrote:
> On Tuesday 26 May 2009 21:05:02 Aaron J. Seigo wrote:
>> On Tuesday 26 May 2009, Petri Damstén wrote:
>> > Yes, seems to be called only once now. I think it still gets called when
>> > Cancel is pressed if configLoader == 0?
>>
>> this should
On Wednesday 27 May 2009, Petri Damstén wrote:
> On Tuesday 26 May 2009 21:05:02 Aaron J. Seigo wrote:
> > On Tuesday 26 May 2009, Petri Damstén wrote:
> > > Yes, seems to be called only once now. I think it still gets called
> > > when Cancel is pressed if configLoader == 0?
> >
> > this should be
On Tuesday 26 May 2009 21:05:02 Aaron J. Seigo wrote:
> On Tuesday 26 May 2009, Petri Damstén wrote:
> > Yes, seems to be called only once now. I think it still gets called when
> > Cancel is pressed if configLoader == 0?
>
> this should be better in trunk now. testing with the javascript
> Plasma:
On Tuesday 26 May 2009, Petri Damstén wrote:
> Yes, seems to be called only once now. I think it still gets called when
> Cancel is pressed if configLoader == 0?
this should be better in trunk now. testing with the javascript
Plasma::ScriptEngine i'm only getting configChanged calls when the conf
On Tuesday 26 May 2009 16:19:39 Aaron J. Seigo wrote:
> right, we probably don't need the applet to also say the config has changed
> if (but only if!) we have a config loader, so something like this in
> AppletPrivate::configDialogFinished():
>
> if (!configLoader) {
> // manually call configC
On Tuesday 26 May 2009, Petri Damstén wrote:
> plasmoidviewer with python applet start (configChanged called 4 times):
hm... too many calls to writeConfig are happening, and KConfigSkeleton is Too
Dumb(tm) to know that nothing's actually changed. i'll take a look in a bit
about this.
(i don't t
Hi,
Testing python applet and noticed that configChanged is not forwarded to
python applets (attached diff).
Currently configChanged is called multiple times at start and at config dialog
close. Should Plasma take care of calling configChanged just once in these
situations?
plasmoidviewer wi