Re: Review Request: Preconfigurable plasmoids

2011-05-05 Thread David Palacio
> On April 28, 2011, 9:19 p.m., Aaron J. Seigo wrote: > > an interesting idea, but the configuration values should not appear in the > > metadata.desktop file. it not only bloats up the # of keys we have, it > > doesn't scale to plasmoids with more/different configuration. > > > > i think this

Re: Review Request: Preconfigurable plasmoids

2011-05-05 Thread Aaron J. Seigo
> On April 28, 2011, 9:19 p.m., Aaron J. Seigo wrote: > > an interesting idea, but the configuration values should not appear in the > > metadata.desktop file. it not only bloats up the # of keys we have, it > > doesn't scale to plasmoids with more/different configuration. > > > > i think this

Re: Review Request: Preconfigurable plasmoids

2011-05-04 Thread David Palacio
> On April 28, 2011, 9:19 p.m., Aaron J. Seigo wrote: > > an interesting idea, but the configuration values should not appear in the > > metadata.desktop file. it not only bloats up the # of keys we have, it > > doesn't scale to plasmoids with more/different configuration. > > > > i think this

Re: Review Request: Preconfigurable plasmoids

2011-05-04 Thread David Palacio
> On April 28, 2011, 9:19 p.m., Aaron J. Seigo wrote: > > an interesting idea, but the configuration values should not appear in the > > metadata.desktop file. it not only bloats up the # of keys we have, it > > doesn't scale to plasmoids with more/different configuration. > > > > i think this

Re: Review Request: Preconfigurable plasmoids

2011-05-03 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/ --- (Updated May 4, 2011, 12:52 a.m.) Review request for Plasma. Changes ---

Re: Review Request: Preconfigurable plasmoids

2011-05-01 Thread Aaron J. Seigo
> On April 29, 2011, 10:24 a.m., Aaron J. Seigo wrote: > > plasma/pluginloader.cpp, line 119 > > > > > > config does not need to cascade. you only need a KSimpleConfig here > > David Palacio wrote: > SimpleConf

Re: Review Request: Preconfigurable plasmoids

2011-04-30 Thread David Palacio
> On April 29, 2011, 10:24 a.m., Aaron J. Seigo wrote: > > plasma/pluginloader.cpp, line 121 > > > > > > applet->config() probably does not return the actual config group, but > > a temporary group that gets migrat

Re: Review Request: Preconfigurable plasmoids

2011-04-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/#review2961 --- plasma/pluginloader.cpp

Re: Review Request: Preconfigurable plasmoids

2011-04-28 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/ --- (Updated April 29, 2011, 1:09 a.m.) Review request for Plasma. Summary -

Re: Review Request: Preconfigurable plasmoids

2011-04-28 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/ --- (Updated April 29, 2011, 1:08 a.m.) Review request for Plasma. Changes -

Re: Review Request: Preconfigurable plasmoids

2011-04-28 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/ --- (Updated April 29, 2011, 12:13 a.m.) Review request for Plasma. Changes

Re: Review Request: Preconfigurable plasmoids

2011-04-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/#review2950 --- an interesting idea, but the configuration values should not app

Re: Preconfigurable plasmoids

2011-04-28 Thread David Palacio
On Thu, Apr 28, 2011 at 03:16:45PM -0500, David Palacio wrote: > Greetings Plasma developers, > > There is some code duplication in that some plasmoids share very much of > program logic but actually differ in just a setting. E.g. the recently > made ShowActivityManager plasmoid, which just is a D

Review Request: Preconfigurable plasmoids

2011-04-28 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101251/ --- Review request for Plasma. Summary --- There is some code duplication

Preconfigurable plasmoids

2011-04-28 Thread David Palacio
Greetings Plasma developers, There is some code duplication in that some plasmoids share very much of program logic but actually differ in just a setting. E.g. the recently made ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon plasmoid is an example of this made right. I'