D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package

2019-10-22 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd1f77d5dbff: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY

D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package

2019-10-22 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes. Closed by commit R119:550a9a25d628: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R119

D6041: Port a bunch of classes away from Plasma::Package

2017-06-06 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:563011436d5f: Port a bunch of classes away from Plasma::Package (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15015

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread Aleix Pol Gonzalez
apol added a comment. Yes sure. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread David Edmundson
davidedmundson added a comment. Can we wait till after the next release is tagged as that's super soon and this isn't that important. We've had major bugs porting stuff in this area before. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, al

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread Aleix Pol Gonzalez
apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.h:105 > despite the warning in the header, this ended up being an exported symbol, so > binary compatibility rules apply here too. > Plasma::Package appletPackage() c

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 15015. apol marked an inline comment as done. apol added a comment. Address Marco's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15003&id=15015 BRANCH master REVISION DETAIL http

D6041: Port a bunch of classes away from Plasma::Package

2017-05-31 Thread Marco Martin
ab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;) > appletquickitem.h:105 > > -Plasma::Package appletPackage() const; > - void setAppletPackage(const Plasma::Package &package); > +KPackage::Package appletPackage() const;

D6041: Port a bunch of classes away from Plasma::Package

2017-05-30 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ported away some classes, removes many unneeded casts that happen when starting. TEST PLAN Tests still pass, plasma starts properly

[Differential] [Closed] D3812: Deprecate Plasma::Package API in PluginLoader

2016-12-27 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4798310ed788: Deprecate Plasma::Package API in PluginLoader (authored by graesslin). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3812?vs=9366&id=

[Differential] [Accepted] D3812: Deprecate Plasma::Package API in PluginLoader

2016-12-27 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH deprecate-package-in-pluginloader REVISION DETAIL https://phabricator.kde.org/D3812 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Request, 15 lines] D3812: Deprecate Plasma::Package API in PluginLoader

2016-12-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As Plasma::Package is deprecated API using Plasma::Package should also be deprecated

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- (Updated Feb. 25, 2015, 3:28 p.m.) Status -- This change has been ma

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76398 --- Ship it! Ship It! - Marco Martin On Feb. 21, 2015, 12:56 p

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- (Updated Feb. 21, 2015, 1:56 p.m.) Review request for Plasma. Changes -

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Marco Martin
> On Feb. 16, 2015, 6:38 p.m., Kai Uwe Broulik wrote: > > Can't we resurrect, for instance, the X-Plasma-RequiredExtensions thing or > > so? I don't want to end up with dozens of X-Plasma-Requires-Internet, > > X-Plasma-Requires-This-and-that +1, it can be X-Plasma-RequiredExtensions=ExternalS

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76152 --- Can't we resurrect, for instance, the X-Plasma-RequiredExtensi

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76149 --- Ship it! +1, could you just add a short paragraph about this

Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Vishesh Handa
On Tue, Sep 16, 2014 at 2:19 PM, Marco Martin wrote: > right now all the classes are still under the Plasma namespace, and should > probably be renamed and cmakes to be cleaned up (especially because it > would > be used by plasma too to the two identically named classes, new and > deprecated > w

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Sebastian Kügler
On Wednesday, September 17, 2014 11:20:10 Marco Martin wrote: > On Wednesday 17 September 2014 11:06:50 Martin Gräßlin wrote: > > > Is the name ok for everybody? potential name clashes? > > > > as it used to be namespaces before, what about using a namespace KPackage > > and just call the classes:

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Marco Martin
On Wednesday 17 September 2014 11:06:50 Martin Gräßlin wrote: > > Is the name ok for everybody? potential name clashes? > > as it used to be namespaces before, what about using a namespace KPackage > and just call the classes: > KPackage::Package > KPackage::PackageStructure > KPackage::PackageTra

Re: Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Martin Gräßlin
On Wednesday 17 September 2014 10:40:35 Marco Martin wrote: > On Tuesday 16 September 2014 14:19:44 Marco Martin wrote: > > right now all the classes are still under the Plasma namespace, and should > > probably be renamed and cmakes to be cleaned up (especially because it > > would be used by plas

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Marco Martin
On Tuesday 16 September 2014 14:19:44 Marco Martin wrote: > right now all the classes are still under the Plasma namespace, and should > probably be renamed and cmakes to be cleaned up (especially because it would > be used by plasma too to the two identically named classes, new and > deprecated wo

Initial standalone Plasma::Package repository

2014-09-16 Thread Marco Martin
Hi all, first, brief introductionon what this is: during a Bof about scripting in applications at Akademy it occurred that some applications may be interested by the functionality provided by Plasma::Package, provided it was on a lower tier. Since I already had kindof the idea of making Package

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread Kevin Krammer
On Monday, 2014-05-26, 10:58:06, Marco Martin wrote: > On Saturday 24 May 2014, Kevin Krammer wrote: > > Since I remembered reading about some form of packaging being developed > > for > > Plasma years ago I went to TechBase and read up a bit on Plasma Package. > > &g

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread Marco Martin
ailable as a framework. > > One of the features that would likely be interesting to most application > developers is how to handle installation and runtime detection of available > scripts. > > Since I remembered reading about some form of packaging being developed for > Pla

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread David Edmundson
> Are there any Plasma specific dependencies in the current code? Not really. In terms of dependencies, it's pretty much: KArchive KService KI8n (could be dropped) David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/li

Re: Plasma Package -> Application Extension Framework?

2014-05-25 Thread Aleix Pol
ing developed for > Plasma years ago I went to TechBase and read up a bit on Plasma Package. > > What are your opinions on having that in a generic "app extension" > framework? > Are there any Plasma specific dependencies in the current code? > > Cheers, >

Plasma Package -> Application Extension Framework?

2014-05-24 Thread Kevin Krammer
developers is how to handle installation and runtime detection of available scripts. Since I remembered reading about some form of packaging being developed for Plasma years ago I went to TechBase and read up a bit on Plasma Package. What are your opinions on having that in a generic "app exte

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Sebastian Kügler
On Thursday, July 25, 2013 16:02:53 Michael Bohlender wrote: > On Thu, Jul 25, 2013 at 4:00 PM, Michael Bohlender wrote: > > I am using plasma components outside of a plasma package in kmail-mobile > > and some components don't get displayed / themed correctly. > > &g

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Michael Bohlender
On Thu, Jul 25, 2013 at 4:00 PM, Michael Bohlender < michael.bohlen...@gmail.com> wrote: > > > I am using plasma components outside of a plasma package in kmail-mobile >> and >> > some components don't get displayed / themed correctly. >> &g

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Sebastian Kügler
Hi Michael, On Thursday, July 25, 2013 14:22:09 Michael Bohlender wrote: > I am using plasma components outside of a plasma package in kmail-mobile and > some components don't get displayed / themed correctly. > > # PageRow: bordershadows not visible > > " > fi

plasma components outside of a plasma package / GSoC

2013-07-25 Thread Michael Bohlender
I am using plasma components outside of a plasma package in kmail-mobile and some components don't get displayed / themed correctly. # PageRow: bordershadows not visible " file:///opt/kde4/lib/kde4/imports/org/kde/plasma/extras/PageRow.qml:316:13: QML QDeclarativeImage_QML_25: Fai

Re: questions about Plasma Package

2011-12-27 Thread Sebastian Kügler
Hey Giorgos, On Saturday, December 24, 2011 16:05:31 Giorgos Tsiapaliwkas wrote: > here some questions about the plasma package > > 1.every plasmoid has these 3 dirs code,data,animations. > What kind of files should exist in those 3? > Does those 3 have any "special"

questions about Plasma Package

2011-12-24 Thread Giorgos Tsiapaliwkas
Hello, here some questions about the plasma package 1.every plasmoid has these 3 dirs code,data,animations. What kind of files should exist in those 3? Does those 3 have any "special" effects to the plasmoids like the ui/config.ui? 2.in the declarative-plasmoids repository there i

Re: Review Request: Do not check if a wallpaper is a valid Plasma::Package

2011-05-06 Thread Raphael Kubo da Costa
wboard.kde.org/r/101302/#review3150 --- On May 6, 2011, 5:17 a.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request: Do not check if a wallpaper is a valid Plasma::Package

2011-05-06 Thread Aaron J. Seigo
On May 6, 2011, 5:17 a.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101302/ > --- > > (Updated May 6

Re: Review Request: Do not check if a wallpaper is a valid Plasma::Package

2011-05-06 Thread Aaron J. Seigo
tomatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101302/ > --- > > (Updated May 6, 2011, 5:17 a.m.) > > > Review request for Plasma. > > > Summary > --- > > Do not check if the created Plasma::Package is valid. >

Review Request: Do not check if a wallpaper is a valid Plasma::Package

2011-05-05 Thread Raphael Kubo da Costa
Plasma::Package is valid. Wallpapers consisting of a single image (without a .desktop metadata or anything else), usually obtained via GHNS, are not valid packages, but are valid wallpapers. Commit b60136e, besides moving the loading code to a separate thread, also started checking if a

Re: Plasma::Package::registerPackage stops working?

2009-07-26 Thread Dong Tiger
2009/7/25 Aaron J. Seigo > On Friday 24 July 2009, Dong Tiger wrote: > > After removing the line of "X-KDE-ParentApp=", it appears in the dialog. > > aha! and looking at the code in libplasma, the reason for that is fairly > obvious. i'll be committing (and backporting) a fix for this shortly. >

Re: Plasma::Package::registerPackage stops working?

2009-07-24 Thread Aaron J. Seigo
On Friday 24 July 2009, Dong Tiger wrote: > After removing the line of "X-KDE-ParentApp=", it appears in the dialog. aha! and looking at the code in libplasma, the reason for that is fairly obvious. i'll be committing (and backporting) a fix for this shortly. thanks for tracking down the exact i

Re: Plasma::Package::registerPackage stops working?

2009-07-24 Thread Dong Tiger
Aaron J. Seigo >> > >> > > On Wednesday 22 July 2009, Dong Tiger wrote: >> > > > I found I can't add Google Gadget into plasma any more. Google >> Gadget >> > > > in plasma uses Plasma::Package::registerPackage to add gadgets into >>

Re: Plasma::Package::registerPackage stops working?

2009-07-23 Thread Dong Tiger
On Wednesday 22 July 2009, Dong Tiger wrote: > > 2009/7/23 Aaron J. Seigo > > > > > On Wednesday 22 July 2009, Dong Tiger wrote: > > > > I found I can't add Google Gadget into plasma any more. Google > Gadget > > > > in plasma uses Plasma::Pac

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Aaron J. Seigo
On Wednesday 22 July 2009, Dong Tiger wrote: > 2009/7/23 Aaron J. Seigo > > > On Wednesday 22 July 2009, Dong Tiger wrote: > > > I found I can't add Google Gadget into plasma any more. Google Gadget > > > in plasma uses Plasma::Package::registerPacka

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Dong Tiger
2009/7/23 Aaron J. Seigo > On Wednesday 22 July 2009, Dong Tiger wrote: > > I found I can't add Google Gadget into plasma any more. Google Gadget in > > plasma uses Plasma::Package::registerPackage to add gadgets into plasma. > It > > used to work. > > * is

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Aaron J. Seigo
On Wednesday 22 July 2009, Dong Tiger wrote: > I found I can't add Google Gadget into plasma any more. Google Gadget in > plasma uses Plasma::Package::registerPackage to add gadgets into plasma. It > used to work. * is the pluginName() set in the Plasma::PackageMetadata obje

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Dong Tiger
> > > > I found I can't add Google Gadget into plasma any more. Google Gadget in > > plasma uses Plasma::Package::registerPackage to add gadgets into plasma. > It > > used to work. > > > > I saw there is another method installPackage in Plasma::Package. Sho

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Federico Manganelli
In data mercoledì 22 luglio 2009 08:29:59, Dong Tiger ha scritto: : > Hi, > > I found I can't add Google Gadget into plasma any more. Google Gadget in > plasma uses Plasma::Package::registerPackage to add gadgets into plasma. It > used to work. > > I saw there is anothe

Re: Plasma::Package::registerPackage stops working?

2009-07-22 Thread Marco Martin
On Wednesday 22 July 2009, Dong Tiger wrote: > Hi, > > I found I can't add Google Gadget into plasma any more. Google Gadget in > plasma uses Plasma::Package::registerPackage to add gadgets into plasma. It > used to work. > > I saw there is another method installPackage

Plasma::Package::registerPackage stops working?

2009-07-21 Thread Dong Tiger
Hi, I found I can't add Google Gadget into plasma any more. Google Gadget in plasma uses Plasma::Package::registerPackage to add gadgets into plasma. It used to work. I saw there is another method installPackage in Plasma::Package. Should it be used instead of registerPackage? One more th

Re: Plasma package

2008-09-26 Thread Aaron J. Seigo
On Friday 26 September 2008, Petri Damstén wrote: > hi, > > This patch enables custom packages to use default install function by > adding defaultPackageRoot and servicePrefix to package handling. nice.. something i've been wanting to get to for quite a while =) -- Aaron J. Seigo humru othro a k

Plasma package

2008-09-26 Thread Petri Damstén
hi, This patch enables custom packages to use default install function by adding defaultPackageRoot and servicePrefix to package handling. Petri Index: libs/plasma/package.h === --- libs/plasma/package.h (revision 865053) +++ libs/