Re: Plasma::ToolTipManager API review

2008-10-22 Thread Aaron J. Seigo
On Wednesday 22 October 2008, Alexis Ménard wrote: > QGraphicsWidgets ; Solution : then can overload event() method and catch ... which would need to be done with each and every non-Applet widget. so the end result is this: * Applet derived classes would still need to call setToolTip just as we

Re: Plasma::ToolTipManager API review

2008-10-22 Thread Alexis Ménard
I noticed a problem, In the new taskbar QGraphicsWidget are never deleted, so the tooltip is never unregistered Otherwhise in Qt the Tooltip event is generate by the QApplication and each widget react to this event if a tooltip content is set. It's radically different from here. Of course usi

Re: Plasma::ToolTipManager API review

2008-10-21 Thread Kevin Ottens
Le Tuesday 21 October 2008, Aaron J. Seigo a écrit : > > > > * void setToolTipContent (QGraphicsWidget *widget, const > > > > ToolTipContent &data) > > > > > > > > This one is very much used. Should stay. I'm not sure what to do > > > > about ToolTipContent though. Makes sense internally, but may

Re: Plasma::ToolTipManager API review

2008-10-21 Thread Aaron J. Seigo
On Tuesday 21 October 2008, Kevin Ottens wrote: > Le Tuesday 21 October 2008, Aaron J. Seigo a écrit : > > > * void showToolTip (QGraphicsWidget *widget) > > > * void delayedHideToolTip () > > > * void hideToolTip (QGraphicsWidget *widget) > > > > the first one was used in a recent patch unti

Re: Plasma::ToolTipManager API review

2008-10-21 Thread Kevin Ottens
Le Tuesday 21 October 2008, Aaron J. Seigo a écrit : > > * void showToolTip (QGraphicsWidget *widget) > > * void delayedHideToolTip () > > * void hideToolTip (QGraphicsWidget *widget) > > the first one was used in a recent patch until i changed the patch ;) but i > think there are reasonable

Re: Plasma::ToolTipManager API review

2008-10-20 Thread Aaron J. Seigo
On Monday 20 October 2008, Aaron J. Seigo wrote: > removed toolTip from the method names yet. done > i also need to add the tooltip inhibition code done -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by

Re: Plasma::ToolTipManager API review

2008-10-20 Thread Aaron J. Seigo
On Monday 20 October 2008, Aaron J. Seigo wrote: > On Monday 20 October 2008, Kevin Ottens wrote: > > Surprisingly (or not) my conclusions on this one will be radical. I think done all the ones i agree with. now to battle it out over the remainder. oh, and i haven't made it static methods or remo

Re: Plasma::ToolTipManager API review

2008-10-20 Thread Aaron J. Seigo
On Monday 20 October 2008, Kevin Ottens wrote: > Surprisingly (or not) my conclusions on this one will be radical. I think =P > * ToolTipManager (QObject *parent=0) > * ~ToolTipManager () > > ToolTipManager being a singleton, I'd say they probably shouldn't be > public. Even better, to get closer

Plasma::ToolTipManager API review

2008-10-20 Thread Kevin Ottens
Hello, I took some time tonight to take a look at Plasma::ToolTipManager API since it was reasonably self contained, and I could work on it without having to wait for some on-going effort. Surprisingly (or not) my conclusions on this one will be radical. I think quite a few methods can be remo