Re: Plasma::Service API addition

2012-05-14 Thread Alex Merry
On 13/05/12 14:48, Aaron J. Seigo wrote: On Friday, May 11, 2012 17:29:44 Alex Merry wrote: It's probably worth considering the interaction between Plasma::Service and declarative applets generally. I ran into issues with keeping around an instance of Plasma::Service (I tried to keep it as a Qt

Re: Plasma::Service API addition

2012-05-13 Thread Aaron J. Seigo
On Friday, May 11, 2012 17:29:44 Alex Merry wrote: > On 11/05/12 12:18, Aaron J. Seigo wrote: > > On Friday, May 11, 2012 11:59:59 Alex Merry wrote: > >> What's the best thing to do here? > > > > i just reviewed the change; it can go in imho. it's a short term fix, > > though, as we need to chnage

Re: Plasma::Service API addition

2012-05-11 Thread Alex Merry
On 11/05/12 12:18, Aaron J. Seigo wrote: On Friday, May 11, 2012 11:59:59 Alex Merry wrote: What's the best thing to do here? i just reviewed the change; it can go in imho. it's a short term fix, though, as we need to chnage this for libplasma2... It's probably worth considering the interact

Re: Plasma::Service API addition

2012-05-11 Thread Aaron J. Seigo
On Friday, May 11, 2012 11:59:59 Alex Merry wrote: > What's the best thing to do here? i just reviewed the change; it can go in imho. it's a short term fix, though, as we need to chnage this for libplasma2... -- Aaron Seigo signature.asc Description: This is a digitally signed message part. __

Plasma::Service API addition

2012-05-11 Thread Alex Merry
So I was about to commit the new nowplaying QML plasmoid to kdeplasma-addons, when I realised that it depends on the API additions in https://git.reviewboard.kde.org/r/104760/, which doesn't appear to have been looked at. Now we're actually past the soft feature freeze, and while I put the mpris2