Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

2009-09-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2415 --- Ship it! to me the patch it's fine (and the webbrowser plasmoid shoul

Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

2009-09-22 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-09-22 10:30:38.640491) Review request for Plasma, Aaron Seigo and

Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

2009-08-31 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-08-31 16:26:07.434735) Review request for Plasma, Aaron Seigo and

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Michal Dutkiewicz
> On 2009-08-30 19:40:51, Aaron Seigo wrote: > > i'm fine with this going in; line edit and text edits too, i think. but > > spinbox? i don't think it's that common to subclass it ...? OK, so maybe I'll add these widgets and then upload one bigger patch, tomorrow I'll have someone to test code

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2193 --- Ship it! i'm fine with this going in; line edit and text edits too, i

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-08-30 16:39:32.923467) Review request for Plasma, Aaron Seigo and

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-23 Thread Marco Martin
On Thursday 23 July 2009, Michal Dutkiewicz wrote: > > On 2009-07-23 04:12:32, Aaron Seigo wrote: > > > if this is needed (which it may be in this case) then it should not be > > > done using a constructor imo but rather a setNativeWidget method. that > > > a combobox is created and then discarded

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-23 Thread Michal Dutkiewicz
> On 2009-07-23 04:12:32, Aaron Seigo wrote: > > if this is needed (which it may be in this case) then it should not be done > > using a constructor imo but rather a setNativeWidget method. that a > > combobox is created and then discarded in the process is a non-issue (it's > > not a hot path

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-22 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1722 --- if this is needed (which it may be in this case) then it should not be

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-22 Thread Sebastian Kügler
On Tuesday 21 July 2009 17:55:33 Michal Dutkiewicz wrote: > It's intended for 4.3 (better later than never..., didn't know that there > is still no possibility to do something like this and no possibility to > create custom Plasma themed widget). Note that it won't be accepted in 4.3, it's a featu

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-21 Thread Michal Dutkiewicz
oxy that has style taken from widget created in Plasma widget) and there is possible problem with widgets created using: Plasma::ComboBox(NULL)... But we could try to find better solution for 4.4 probably, by adding method that sets own widget instead current, connects signals and slots and

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1705 --- I like the idea,since doesn't make sense a new plasma widget for every

Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-21 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- Review request for Plasma and Marco Martin. Summary --- This patch adds pos

Re: Plasma::ComboBox - not possible to set line edit and keep theming?

2009-04-07 Thread Emdek
On Tuesday 07-04-2009 15:52:39 Marco Martin wrote: > On Tuesday 07 April 2009, Emdek wrote: >> I have question, is it possible to set line edit for Plasma themed combo >> box and not loose it's theme? > comboBox->nativeWidget()->setEditable(true) should work > changing its lineedit not, becausethe

Re: Plasma::ComboBox - not possible to set line edit and keep theming?

2009-04-07 Thread Marco Martin
7;t have the plasma private style > I was trying to use this code: > > Plasma::ComboBox *comboBox = new Plasma::ComboBox(this); > > KLineEdit *lineEdit = new KLineEdit(comboBox->nativeWidget()); > lineEdit->setAttribute(Qt::WA_NoSystemBackground); >

Plasma::ComboBox - not possible to set line edit and keep theming?

2009-04-07 Thread Emdek
Hello I have question, is it possible to set line edit for Plasma themed combo box and not loose it's theme? I was trying to use this code: Plasma::ComboBox *comboBox = new Plasma::ComboBox(this); KLineEdit *lineEdit = new KLineEdit(comboBox->nativeWidget());

Re: Plasma::ComboBox

2009-02-06 Thread Petri Damstén
On Tuesday 03 February 2009 20:16:49 Marco Martin wrote: > no idea about the disappeared labels, So would it better to just disable setting text color: http://kotisivu.lumonetti.fi/damu0/images/combo1.png or set background color (attached diff): http://kotisivu.lumonetti.fi/damu0/images/combo2.p

Re: Plasma::ComboBox

2009-02-04 Thread Petri Damstén
On Tuesday 03 February 2009 20:16:49 Marco Martin wrote: > no idea about the disappeared labels, I think the problem here is that Plasma::ComboBox sets palette for text (in ComboBoxPrivate::syncBorders()) to Theme::TextColor. In Oxygen theme it's white which is the same as combobox po

Re: Plasma::ComboBox

2009-02-04 Thread Petri Damstén
On Tuesday 03 February 2009 20:16:49 Marco Martin wrote: > no idea about the disappeared labels, the combo is under the other widgets > becauseit's in a proxywidget too (probably won't change for a while but > iirc this could become controllable in the future), so you should set a big > zvalue in t

Re: Plasma::ComboBox

2009-02-03 Thread Aaron J. Seigo
On Tuesday 03 February 2009, Marco Martin wrote: > becauseit's in a proxywidget too (probably won't change for a while but > iirc this could become controllable in the future), i believe the plan is to address this in Qt 4.6 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C

Re: Plasma::ComboBox

2009-02-03 Thread Marco Martin
On Tuesday 03 February 2009, Petri Damstén wrote: > Hi, > > I converted 'unit converter'-applet to plasma widgets, but I have a problem > with Plasma::ComboBox http://kotisivu.lumonetti.fi/damu0/images/combo.png > ComboBox is under the other widgets and only the select

Plasma::ComboBox

2009-02-03 Thread Petri Damstén
Hi, I converted 'unit converter'-applet to plasma widgets, but I have a problem with Plasma::ComboBox http://kotisivu.lumonetti.fi/damu0/images/combo.png ComboBox is under the other widgets and only the selected item shows text. Any ideas what might be wrong here? Petri sig