Re: Patch Review

2013-05-15 Thread Sinny Kumari
Cool! patch works fine :) On Thu, May 16, 2013 at 2:17 AM, Marco Martin wrote: > On Wednesday 15 May 2013, Akshay Ratan wrote: > > Hi, > > With regard to the bug :: > https://bugs.kde.org/show_bug.cgi?id=319626 , > > I have submitted a patch for review. Its a very minor change as per the >

Re: Patch Review

2013-05-15 Thread Marco Martin
On Wednesday 15 May 2013, Akshay Ratan wrote: > Hi, > With regard to the bug :: https://bugs.kde.org/show_bug.cgi?id=319626 , > I have submitted a patch for review. Its a very minor change as per the > idea suggestion by Shantanu. Please let me know if further changes are to > be discussed :) >

Re: Patch Review

2013-05-15 Thread Akshay Ratan
Hi, With regard to the bug :: https://bugs.kde.org/show_bug.cgi?id=319626 , I have submitted a patch for review. Its a very minor change as per the idea suggestion by Shantanu. Please let me know if further changes are to be discussed :) I have simply removed the visible tag in the Plasma Tool

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-18 Thread Sascha Peilicke
On Wednesday 17 December 2008 12:53:30 Frederik Gladhorn wrote: > Hi Sascha, > thanks for looking at the marble wallpaper - that's much appreciated from > my side :) > I have had no time to look at the patch at all yet, will do so on the > weekend. I attached a more current one here :-) > > On Mon

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-17 Thread Frederik Gladhorn
Hi Sascha, thanks for looking at the marble wallpaper - that's much appreciated from my side :) I have had no time to look at the patch at all yet, will do so on the weekend. On Monday 15 December 2008 21:41:16 Sascha Peilicke wrote: > For Frederic Gladhorn and FYI. > > > This patch adds/changes

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-16 Thread Aaron J. Seigo
On Tuesday 16 December 2008, Alex Merry wrote: > On Tuesday 16 December 2008 08:46:41 Sascha Peilicke wrote: > > Agreed, my issue is that "The Earth" is currently able to show "The Moon" > > (the rest of our solar system may follow), so maybe just "Globe" is > > better. > > I think most English-spe

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-16 Thread Alex Merry
On Tuesday 16 December 2008 08:46:41 Sascha Peilicke wrote: > Agreed, my issue is that "The Earth" is currently able to show "The Moon" > (the rest of our solar system may follow), so maybe just "Globe" is better. I think most English-speaking folks would know what a "Globe" was. Especially if t

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-16 Thread Sascha Peilicke
On Monday 15 December 2008 23:16:32 Aaron J. Seigo wrote: > On Monday 15 December 2008, Sascha Peilicke wrote: > > Mouse interaction was removed completely, this caused all sort of weird > > troubles when interacting with plasma widgets (instead rotates the globe > > or vice versa). > > are you say

Re: [PATCH] Review request for plasma marble wallpaper (playground)

2008-12-15 Thread Aaron J. Seigo
On Monday 15 December 2008, Sascha Peilicke wrote: > Mouse interaction was removed completely, this caused all sort of weird > troubles when interacting with plasma widgets (instead rotates the globe or > vice versa). are you saying that mouse events passed to the wallpaper would end up passed t

[PATCH] Review request for plasma marble wallpaper (playground)

2008-12-15 Thread Sascha Peilicke
For Frederic Gladhorn and FYI. This patch adds/changes a lot of features to the marble plasma wallpaper in playground. Re-enabled the stars plugin as current Marble trunk doesn't seem to crash on it any further. Moved to a more generic support for globe rotation schemes to allow something l

akademy vs patch review =)

2008-08-13 Thread Aaron J. Seigo
hi all.. i see several patches on the list that are waiting for review, etc. i'm at akademy right now and won't have time to do any patch review until it's over. i return home on tuesday, so wednesday is probably the worst case scenario. perhaps others can do some patch review