Re: Panel icon sizing bug in 4.4

2010-06-07 Thread Aaron J. Seigo
On June 3, 2010, Mike Kasick wrote: > Would it be possible to commit this to the 4.4 branch? I'd love to see i think most of us are stupidly busy as it is right now getting 4.5 out. if you can test these changes against 4.4 and confirm they work properly, then please commit. at least i don't ha

Re: Panel icon sizing bug in 4.4

2010-06-07 Thread Mike Kasick
On Thu, Jun 03, 2010 at 07:50:24PM -0400, Mike Kasick wrote: > I've gone through SVN and cherry-picked the patches for each applet and > backported them to the KDE 4.4 SVN branch--keeping just the changes > relevant to iconSizeChanged/sizeHint as well as setting of the Panel icon > size in kcm_ico

Re: Panel icon sizing bug in 4.4

2010-06-03 Thread Mike Kasick
On Tue, May 25, 2010 at 12:38:44PM -0700, Aaron J. Seigo wrote: > > Is there a chance this will make it into 4.4.4? If not, I might want to > > i highly doubt it, sorry :( Thanks for your effors in getting this into trunk. The latest revisions (with MenuLauncherApplet::sizeHint defined const)

Re: Panel icon sizing bug in 4.4

2010-06-02 Thread Aaron J. Seigo
On June 2, 2010, todd rme wrote: > So for horizontal panels it resizes freely, but for vertical panels it > only goes up to the maximum size specified? Wouldn't that fix the because that doesn't address the issue that some people want LARGE icons in a horizontal panel and others don't. the diff

Re: Panel icon sizing bug in 4.4

2010-06-02 Thread todd rme
On Sun, May 23, 2010 at 9:29 PM, Mike Kasick wrote: > On Sun, May 23, 2010 at 10:28:00AM -0700, Chani wrote: > >> one of the bug reports mentioned that KDE's default icon size should be >> respected, although it's not clear whether that was implemented. > > It wasn't. > >> if that setting is not f

Re: Panel icon sizing bug in 4.4

2010-06-02 Thread Ivan Čukić
> One more issue: the "simple" Application Launcher Menu (which I prefer to > kickoff) needs to be fixed too. Attached is a patch based on the Icon > applet changes that fixes the MenuLauncher applet too. Sorry, my bad, forgot to commit the changes... it should be ok now. Cheerio, Ivan -- Whil

Re: Panel icon sizing bug in 4.4

2010-06-01 Thread Mike Kasick
On Tue, May 25, 2010 at 12:38:44PM -0700, Aaron J. Seigo wrote: > there was one commit per set of files changed; so one for PopupApplet in > libplasma, one for kickoff, one for lancelot (iirc?) and one for the control > panel. I tested these out, they work great! One more issue: the "simple" A

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 25, 2010, Mike Kasick wrote: > On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote: > > kickoff is a popup applet should be handled by PopupApplet and so > > shouldn't be patched for this. > > The "new-style" kickoff is indeed, I don't think the patches touch > the regular Launch

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Mike Kasick
On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote: > kickoff is a popup applet should be handled by PopupApplet and so shouldn't > be > patched for this. The "new-style" kickoff is indeed, I don't think the patches touch the regular LauncherApplet. The "old-style" kickoff (better

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 24, 2010, Mike Kasick wrote: > On Mon, May 24, 2010 at 10:56:53AM +0200, Marco Martin wrote: > > What should be modified i think is the size hint of the Icon applet, in > > workspace, that is explicitly used here > > and should have a sizehint of Panel in vertical/horizontal formfactors > >

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Aaron J. Seigo
On May 23, 2010, Rhapsody wrote: > On 23/05/10 18:08, Ivan Čukić wrote: > > As far as I know, it is intentional, that is, it is not a bug. > > > > From my point of view, this is something that we can make configurable > > (there already is a configuration page in system settings> application > >

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Ivan Čukić
> Seems to do the trick on my end. Your thoughts? p.s. Do you have SVN account? Cheerio, Ivan -- You know, there are many people in the country today who, through no fault of their own, are sane. Some of them were born sane. Some of them became sane later in their lives... -- Monty Python

Re: Panel icon sizing bug in 4.4

2010-05-25 Thread Ivan Čukić
> Seems to do the trick on my end. Your thoughts? popupapplet:866 When on desktop, popup applet is not an icon, so it should return Plasma::Applet::sizeHint(...) Other things seem ok Cheerio, Ivan -- The bleeding hearts and artists, Make their stand. -- Pink Floyd _

Re: Panel icon sizing bug in 4.4

2010-05-24 Thread Ivan Čukić
This will be needed in Plasma::PopupApplet as well. I'll can do it when this gets accepted. Cheerio -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-dev

Re: Panel icon sizing bug in 4.4

2010-05-24 Thread Mike Kasick
On Mon, May 24, 2010 at 10:56:53AM +0200, Marco Martin wrote: > What should be modified i think is the size hint of the Icon applet, in > workspace, that is explicitly used here > and should have a sizehint of Panel in vertical/horizontal formfactors and > Desktop in Planar OK. Attached is a p

Re: Panel icon sizing bug in 4.4

2010-05-24 Thread Marco Martin
On Monday 24 May 2010, Mike Kasick wrote: > On Sun, May 23, 2010 at 10:28:00AM -0700, Chani wrote: > > one of the bug reports mentioned that KDE's default icon size should be > > respected, although it's not clear whether that was implemented. > > It wasn't. > > > if that setting is not followed,

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Mike Kasick
On Sun, May 23, 2010 at 10:28:00AM -0700, Chani wrote: > one of the bug reports mentioned that KDE's default icon size should be > respected, although it's not clear whether that was implemented. It wasn't. > if that setting is not followed, then you have found a bug, and patches > are welcome.

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Chani
On May 23, 2010 13:08:57 Marco Martin wrote: > On Sunday 23 May 2010, Chani wrote: > > On May 23, 2010 10:27:26 Rhapsody wrote: > > > On 23/05/10 18:08, Ivan Čukić wrote: > > > > As far as I know, it is intentional, that is, it is not a bug. > > > > > > > > From my point of view, this is something

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Marco Martin
On Sunday 23 May 2010, Chani wrote: > On May 23, 2010 10:27:26 Rhapsody wrote: > > On 23/05/10 18:08, Ivan Čukić wrote: > > > As far as I know, it is intentional, that is, it is not a bug. > > > > > > From my point of view, this is something that we can make configurable > > > (there already is a

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Ivan Čukić
> wait a sec... it's not greyed out for me. I can change the icon size. > however, X randomly crashed before I could test whether plasma follows it. > now I'm pissed off at my computer, so I'm gonna go do something else. Strange, for the panel icon, it was disabled (for me) since I can remember :

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Chani
On May 23, 2010 11:02:33 Chani wrote: > On May 23, 2010 10:27:26 Rhapsody wrote: > > On 23/05/10 18:08, Ivan Čukić wrote: > > > As far as I know, it is intentional, that is, it is not a bug. > > > > > > From my point of view, this is something that we can make configurable > > > (there already is

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Chani
On May 23, 2010 10:27:26 Rhapsody wrote: > On 23/05/10 18:08, Ivan Čukić wrote: > > As far as I know, it is intentional, that is, it is not a bug. > > > > From my point of view, this is something that we can make configurable > > (there already is a configuration page in system settings> applicat

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Rhapsody
On 23/05/10 18:08, Ivan Čukić wrote: > > As far as I know, it is intentional, that is, it is not a bug. > > From my point of view, this is something that we can make configurable (there > already is a configuration page in system settings> application appearance> > icons> advanced, *but the size

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Chani
On May 23, 2010 09:53:15 Mike Kasick wrote: > Hi folks, > > This issue was first raised on the KDE community forums [1], for which > my reply is fifth in the thread. It was recommended that I post the > issue here. > I recommend that you search bko first next time. :) https://bugs.kde.org/show

Re: Panel icon sizing bug in 4.4

2010-05-23 Thread Ivan Čukić
> There appears to be a bug, or at least a change in behavior for panel icon > sizing in KDE 4.4 (specifically Debian 4.4.3-2). In previous versions of > KDE (e.g., 4.3), panel icons would resize with the panel up to at least > 48x48. However, as of KDE 4.4 panel icons appear to be restricted to

Panel icon sizing bug in 4.4

2010-05-23 Thread Mike Kasick
Hi folks, This issue was first raised on the KDE community forums [1], for which my reply is fifth in the thread. It was recommended that I post the issue here. There appears to be a bug, or at least a change in behavior for panel icon sizing in KDE 4.4 (specifically Debian 4.4.3-2). In previou