Re: Pager config not working with vertical Panel

2009-07-28 Thread Aaron J. Seigo
On Tuesday 28 July 2009, Anthony Bryant wrote: > On Tue, Jul 28, 2009 at 9:46 PM, Aaron J. Seigo wrote: > > whew! ok :) Anthony: can you commit your patch then and backport it? > > thanks. > > I would if I had an svn account - could you do it for me? ah, right, we just had that conversation the ot

Re: Pager config not working with vertical Panel

2009-07-28 Thread Anthony Bryant
On Tue, Jul 28, 2009 at 9:46 PM, Aaron J. Seigo wrote: > whew! ok :) Anthony: can you commit your patch then and backport it? thanks. I would if I had an svn account - could you do it for me? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mai

Re: Pager config not working with vertical Panel

2009-07-28 Thread Aaron J. Seigo
On Tuesday 28 July 2009, Richard Dale wrote: > On Tue, Jul 28, 2009 at 5:58 PM, Anthony Bryant wrote: > > I'm not completely sure, but I think somehow you weren't running my > > patch when you tried to test it... > > I've definitely fixed the problem you described here. > > My apologies. I think I

Re: Pager config not working with vertical Panel

2009-07-28 Thread Richard Dale
On Tue, Jul 28, 2009 at 5:58 PM, Anthony Bryant wrote: > On Tue, Jul 28, 2009 at 4:00 PM, Richard Dale wrote: >> I have four virtual desktops and a vertical panel on the right. If I >> use the configure dialog to set the number of columns to two, it works >> fine, and I have my four desktops in two

Re: Pager config not working with vertical Panel

2009-07-28 Thread Anthony Bryant
On Tue, Jul 28, 2009 at 4:00 PM, Richard Dale wrote: > I have four virtual desktops and a vertical panel on the right. If I > use the configure dialog to set the number of columns to two, it works > fine, and I have my four desktops in two rows and two columns. If I > set the number of columns to o

Re: Pager config not working with vertical Panel

2009-07-28 Thread Richard Dale
On Mon, Jul 27, 2009 at 8:47 PM, Aaron J. Seigo wrote: > On Monday 27 July 2009, Richard Dale wrote: >> The Pager applet in the kde 4.3 branch doesn't work with a Panel >> aligned vertically. The attached patch fixes the bug. > > does the patch on reviewboard fix this for you as well? see: > > http

Re: Pager config not working with vertical Panel

2009-07-27 Thread Aaron J. Seigo
On Monday 27 July 2009, Richard Dale wrote: > The Pager applet in the kde 4.3 branch doesn't work with a Panel > aligned vertically. The attached patch fixes the bug. does the patch on reviewboard fix this for you as well? see: http://reviewboard.kde.org/r/1124/ -- Aaron J. Seigo humru othro a

Pager config not working with vertical Panel

2009-07-27 Thread Richard Dale
The Pager applet in the kde 4.3 branch doesn't work with a Panel aligned vertically. The attached patch fixes the bug. The code before the fix was trying to have only one calculation for setting either the row or the column in the config dialog and then deriving the other dimension, and afterward