Re: Making paths case insensitive in krunner

2009-01-25 Thread Diaa Sami
On Sat, 24 Jan 2009 14:21 -0700, "Aaron J. Seigo" wrote: > > sorry; i tend to lose patches like that in mailing list. which is why we > have > the review board (http://reviewboard.vidsolbach.de/) ... anyways ... > Yes, I knew about it only 2 days ago, it's such a useful reviewing tool. > th

Re: Making paths case insensitive in krunner

2009-01-24 Thread Aaron J. Seigo
On Saturday 24 January 2009, Diaa Sami wrote: > Any comments about the patch? sorry; i tend to lose patches like that in mailing list. which is why we have the review board (http://reviewboard.vidsolbach.de/) ... anyways ... the patch looks alright. there are probably some opportunities for some

Re: Making paths case insensitive in krunner

2009-01-24 Thread Diaa Sami
Any comments about the patch? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
On Mon, 19 Jan 2009 11:08 -0700, "Aaron J. Seigo" wrote: > > however, the code itself needs to be written following our coding style > guidelines: > > http://techbase.kde.org/Policies/Kdelibs_Coding_Style > > qDebug should be kDebug; QString whatever = "" should be > whatever.isEmpty();

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
On Mon, 19 Jan 2009 11:12 -0700, "Aaron J. Seigo" wrote: > On Monday 19 January 2009, Diaa Sami wrote: > > The previous patch had some mistakes, please use this one instead > > what's the difference between the two? (also, could you attach the > patches > rather than include them inline in the

Re: Making paths case insensitive in krunner

2009-01-19 Thread Aaron J. Seigo
On Monday 19 January 2009, Diaa Sami wrote: > The previous patch had some mistakes, please use this one instead what's the difference between the two? (also, could you attach the patches rather than include them inline in the mail? it makes it easier to work with them by making saving to the loc

Re: Making paths case insensitive in krunner

2009-01-19 Thread Aaron J. Seigo
On Monday 19 January 2009, Diaa Sami wrote: > On Sat, 17 Jan 2009 10:50 -0700, "Aaron J. Seigo" wrote: > > sure; if you can come to the list with some patches, i see no reason > > (assuming the performance is still good =) they couldn't go in... > > You can find an initial version of the patch bel

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
The previous patch had some mistakes, please use this one instead Index: kdelibs/plasma/runnercontext.cpp === --- kdelibs/plasma/runnercontext.cpp(revision 911086) +++ kdelibs/plasma/runnercontext.cpp(working copy) @@ -47,6 +

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
On Sat, 17 Jan 2009 10:50 -0700, "Aaron J. Seigo" wrote: > > sure; if you can come to the list with some patches, i see no reason > (assuming the performance is still good =) they couldn't go in... > You can find an initial version of the patch below, it looks like it works fast enough. Altho

Re: Making paths case insensitive in krunner

2009-01-17 Thread Diaa Sami
On Sat, 17 Jan 2009 18:57 +0100, "Ivan Čukić" wrote: > > so what do you think? > Cool idea. > Glad the idea is appealing. > A bit off topic - in the file open/save dialogue, the case-insensitive > completion works only in the name field, and not in the > breadcrumb/location > bar, while it

Re: Making paths case insensitive in krunner

2009-01-17 Thread Ivan Čukić
> so what do you think? Cool idea. A bit off topic - in the file open/save dialogue, the case-insensitive completion works only in the name field, and not in the breadcrumb/location bar, while it does work (as you stated) in Dolphin. Cheerio! -- A positive attitude may not solve all your pro

Re: Making paths case insensitive in krunner

2009-01-17 Thread Aaron J. Seigo
On Friday 16 January 2009, Diaa Sami wrote: > My name is Diaa sami and I'm relatively new to KDE development, recently welcome to KDE, Diaa =) > I've been working on making path completion in KDE case insensitive[1], > which should be more productive, I've already made Konqueror, Dolphin and > th

Making paths case insensitive in krunner

2009-01-16 Thread Diaa Sami
Hi, My name is Diaa sami and I'm relatively new to KDE development, recently I've been working on making path completion in KDE case insensitive[1], which should be more productive, I've already made Konqueror, Dolphin and the file dialogs provide case-insensitive path completion, these changes