D26406: [kickoff] Fix some unqualified root property access

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those will break in Qt 6. Apply suggestions from qmllint TEST PLAN Did kicker/da

D17034: [Kickoff] Fix bad kerning in tab labels

filipf abandoned this revision. filipf added a comment. In D17034#363098 , @ngraham wrote: > FWIW, we already conditionally switch to using QtRendering when using a fractional scale factor throughout the PlasmaComponents library. So there is alr

D17034: [Kickoff] Fix bad kerning in tab labels

ngraham added a comment. FWIW, we already conditionally switch to using QtRendering when using a fractional scale factor throughout the PlasmaComponents library. So there is already a precedent for sometimes using a different renderer to work around visual bugs, and so far it has been much a

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362807 , @rooty wrote: > Also it's hardly random, it's specifically targeted at a label or a //single// portion of the UI that's affected by this gravely and consistently. Yes, I just logged in and out 10

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362808 , @broulik wrote: > > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. > > It does because it's using a `TextEdit` directly to make

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. It does because it's using a `TextEdit` directly to make text selectable rather than a full `TextArea` which would set this automatically int

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362786 , @hein wrote: > This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. The rasterization should be consistent throughout the system and consistent

D17034: [Kickoff] Fix bad kerning in tab labels

hein added a comment. Thanks, that should probably be reverted, although there might have been some reason I'm unaware of in that case since it also sets the font style to outline rendering. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, n

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362786 , @hein wrote: > we can't just randomly sprinkle a different font rasterizer into the UI. Someone's already done this though. Check line 32 on the left here: https://phabricator.kde.org/differentia

D17034: [Kickoff] Fix bad kerning in tab labels

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. Widget explorer also shows this behavior, however this is more a problem of the labels being not aligned to a pixel grid rather than `NativeRendering` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #p

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362739 , @rooty wrote: > > This is actually pretty neat considering Kickoff and Notifications are the only two widgets where this is a noticeable problem. And the icons on the desktop (not a wi

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. (LOL I accidentally removed the comment) NativeRendering really is the gift that keeps on giving. F6432908: nativerendering.png QtRendering renders a lot better. F6432910: qtrendering.png

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. NativeRendering truly is the gift that keeps on giving F6432893: nativerendering.png This is what happens if I specify that JobDetailsItem.qml use QtRendering F6432899: qtrendering.png RE

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. this has been bugging me/us for years, glad you finally decided to patch it :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #plasma Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. **Explanation:** Kerning refers to the spacing between letters in text. It's important to get it right because otherwise the UI can look unprofessional (and ugly). Currently there is a QML bug that renders all NativeRend

D17034: [Kickoff] Fix bad kerning in tab labels

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch explicitly sets the QML text rendering variable for Kickoff tab labels as QtRendering. The effect is that the tab labels

D16697: [Kickoff] Fix context menu not appearing on right-click

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9b25a95c2191: [Kickoff] Fix context menu not appearing on right-click (authored by broulik, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D16697: [Kickoff] Fix context menu not appearing on right-click

ngraham created this revision. ngraham added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right-clicking on list items to bring up a context menu broke with 48b32259e73f3

D9786: [Kickoff] Fix RTL issues

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b127e545b552: [Kickoff] Fix RTL issues (authored by safaalfulaij). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25384&id=25386 REVISION DE

D9786: [Kickoff] Fix RTL issues

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25384. safaalfulaij added a comment. - 0 instead of undefined - change statments order REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25138&id=25384 BRANCH master REVISION DETAIL https://phab

D9786: [Kickoff] Fix RTL issues

broulik added a comment. Looking good! INLINE COMMENTS > ApplicationsView.qml:112 > +// HACK: Align the content to right for RTL locales > +leftMargin: LayoutMirroring.enabled ? Math.max(0, width - > contentWidth) : undefined > + `leftMargin` does not have a `RESET`

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25138. safaalfulaij added a comment. - Align header labels to left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25137&id=25138 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25137. safaalfulaij added a comment. - Just align it correctly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25073&id=25137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 AFF

D9786: [Kickoff] Fix RTL issues

broulik added a comment. Perhaps you could manually set `contentX` to an appropriate value after adding a breadcrumb. I think the issue is that `Flickable` internally is still left-aligned, so I would suggest meddling around with `contentX` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. In https://phabricator.kde.org/D9786#188720, @broulik wrote: > I see. > > How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of > > leftMargin: Math.max(0, width - contentWidth) > Well, that

D9786: [Kickoff] Fix RTL issues

broulik added a comment. I see. How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of leftMargin: Math.max(0, width - contentWidth) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalful

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. I'll answer that here to put some visuals. This is before the patch, all fine, correct direction, but aligned to left: F5633510: step 1.png Here we mirror the graphics of the Flickable: F5633511: step 2.png

D9786: [Kickoff] Fix RTL issues

broulik added inline comments. INLINE COMMENTS > ApplicationsView.qml:127 > depth: 0 > +scale: LayoutMirroring.enabled ? -1 : 1 // Mirror the > already mirrored item back > } Where is it "already mirrored"? I think we're just hiding a di

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. After applying: F5633478: kickoff_after.mp4 Sorry couldn't crop video REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma Cc: plasma-devel, ZrenBot, progw

D9786: [Kickoff] Fix RTL issues

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Fix 2 issues: - the breadcrumbs alignment -

[Differential] [Closed] D2338: [Kickoff] Fix start row for drag not always being correct

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP5eaadb75de3d: [Kickoff] Fix start row for drag not always being correct (authored by net147, committed by bshah). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2338?vs=5642&id=

[Differential] [Closed] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP784b07f26ae8: [Kickoff] Fix being unable to reorder entries in favorites menu after… (authored by net147, committed by bshah). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2337?vs

[Differential] [Accepted] D2338: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. There's still something off when I drag a bottom favorite to the top if often ends up in the wrong place or doesn't move at all. This is with and without this patch, so looks good to me.

[Differential] [Accepted] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bshah, #plasma, broulik Cc

[Differential] [Request, 3 lines] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 345741 TEST PLAN

[Differential] [Updated] D2338: [Kickoff] Fix start row for drag not always being correct

net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg, abet

[Differential] [Updated] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg, abet

[Differential] [Commented On] D2338: [Kickoff] Fix start row for drag not always being correct

net147 added a comment. This is a backport of https://phabricator.kde.org/D2322 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bro

[Differential] [Commented On] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a comment. This is a backport of https://phabricator.kde.org/D2310 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bro

[Differential] [Request, 2 lines] D2338: [Kickoff] Fix start row for drag not always being correct

net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the dra

[Differential] [Closed] D2322: [Kickoff] Fix start row for drag not always being correct

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6b8b17897664: [Kickoff] Fix start row for drag not always being correct (authored by net147, committed by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https

[Differential] [Accepted] D2322: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2322 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma Cc: plasm

[Differential] [Closed] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPae319ac4fbe6: [Kickoff] Fix being unable to reorder entries in favorites menu after… (authored by net147, committed by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST

[Differential] [Updated, 3 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 updated this revision to Diff 5592. net147 added a comment. Added copyright. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2310?vs=5566&id=5592 REVISION DETAIL https://phabricator.kde.org/D2310 AFFECTED FILES applets/kickoff/p

[Differential] [Request, 2 lines] D2322: [Kickoff] Fix start row for drag not always being correct

net147 created this revision. net147 added reviewers: Plasma, broulik. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the dra

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a comment. In https://phabricator.kde.org/D2310#43105, @broulik wrote: > Thanks. This fixes the issue for me. Do you have commit access? I don't have commit access. Please commit this for me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabri

[Differential] [Accepted] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Thanks. This fixes the issue for me. Do you have commit access? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a comment. In https://phabricator.kde.org/D2310#43102, @broulik wrote: > Thanks for your patch! > > Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (l

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik added a comment. Thanks for your patch! Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (like task manager or kicker do it). REPOSITORY rPLASMADESKTOP Plasm

[Differential] [Updated] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 updated the summary for this revision. net147 updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2310 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, #plasma Cc: p

[Differential] [Request, 2 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 created this revision. net147 added a reviewer: Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I have many entries in the favori

Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 10:09 a.m.) Status -- This change has been m

Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/#review84138 --- Ship it! Ship It! - David Edmundson On Aug. 21, 2015, 8:27

Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

> On Aug. 21, 2015, 8:26 a.m., Kai Uwe Broulik wrote: > > applets/kickoff/core/favoritesmodel.cpp, line 133 > > > > > > Should we "future-proof" that also? Ah whoops - Harald

Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 8:27 a.m.) Review request for Plasma. Changes -

Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/#review84130 --- applets/kickoff/core/favoritesmodel.cpp (line 133)

Review Request 124863: [kickoff] Fix default favorites not being initialized correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- Review request for Plasma. Bugs: 351550 https://bugs.kde.org/show_bug

Re: Kickoff fix

On Sunday 31 May 2009, dantti85-...@yahoo.com.br wrote: > Now the attached diff seems to fix better the problem, if > you don't have anything against it I'll commit. looks fine; thanks :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43

Re: Kickoff fix

>On Sunday 31 May 2009, dantti85-...@yahoo.com.br wrote: >> What about doing the old test (isLocalFile || isRelativePath()), this would >> keep the old behavior and add support for relative paths, i believe >> something like http://path_to/thing.desktop will never be relative? > >hm.. probably not.

Re: Kickoff fix

On Sunday 31 May 2009, dantti85-...@yahoo.com.br wrote: > What about doing the old test (isLocalFile || isRelativePath()), this would > keep the old behavior and add support for relative paths, i believe > something like http://path_to/thing.desktop will never be relative? hm.. probably not. so,

Re: Kickoff fix

@kde.org Enviadas: Domingo, 31 de Maio de 2009 2:50:25 Assunto: Re: Kickoff fix On Saturday 30 May 2009, dantti85-...@yahoo.com.br wrote: > The url for these relative paths are like > "Internet/kvirc.desktop", and how does > that http://foo/.../thing.desktop works? I mean > how can

Re: Kickoff fix

On Saturday 30 May 2009, dantti85-...@yahoo.com.br wrote: > The url for these relative paths are like > "Internet/kvirc.desktop", and how does > that http://foo/.../thing.desktop works? I mean > how can one input those? that method is used for the creation of items for most of the views, and it's

Re: Kickoff fix

2009 13:03:14 Assunto: Re: Kickoff fix On Friday 29 May 2009, dantti85-...@yahoo.com.br wrote: > I've made a patch so please take a look, if it's ok, i'll commit. hm.. actually ... this will now break if someone puts http://foo.com/somewhere/thing.desktop won't it? i wonde

Re: Kickoff fix

On Friday 29 May 2009, dantti85-...@yahoo.com.br wrote: > I've made a patch so please take a look, if it's ok, i'll commit. hm.. actually ... this will now break if someone puts http://foo.com/somewhere/thing.desktop won't it? i wonder if we can test the url's protocol, rather than test it for b

Re: Kickoff fix

On Friday 29 May 2009, dantti85-...@yahoo.com.br wrote: > I've made a patch so please take a look, if it's ok, i'll commit. mmm.. relative paths to .desktop files. yes, looks good, pls commit. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1

Kickoff fix

Hi, there is a bug in kickoff when dealing with old applications that install .desktop at applnk. KSycoca returns a relative path and as David Faure said it should be handled in kickoff, in the case what happens is that kvirc from kde3 when added to favorites looses it's icon, and when added to the