D21226: search for a default wallpaper in lookandfeel

2020-01-29 Thread Rik Mills
rikmills added a comment. Would this handle the case where an existing look-and-feel package that did NOT specify a wallpaper, then in a new version adds one? And that occurs on a users system the l-n-f package was already active and plasma is long past 1st plasma start. REPOSITORY R120 P

D21226: search for a default wallpaper in lookandfeel

2020-01-29 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:670f3ec50456: search for a default wallpaper in lookandfeel (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21226?vs=58130&id=74583#toc REPOSITORY R120 Plasma Works

D21226: search for a default wallpaper in lookandfeel

2020-01-29 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. So default wallpaper is effectively via any of: - The active LNF - the plasma theme - LNF/layout.js - desktoppackage/layout.js - containment specific override

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-08 Thread Nathaniel Graham
7 BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D26483 AFFECTED FILES wallpapers/image/image.cpp wallpapers/image/slideshowpackage/contents/config/main.xml To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-08 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > image.cpp:366 > if (m_slidePaths.isEmpty()) { > -m_slidePaths << > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, > QStringLiteral("share/wallpapers"), QStandardPaths::LocateDirectory); > +m_slidePaths << defa

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 73023. ngraham added a comment. Add a `preferred://wallpaperlocations` token and replace it with the real values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=72941&id=73023 BRANCH add-a-def

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread David Edmundson
davidedmundson added a comment. Sure REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalo

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread Nathaniel Graham
ngraham added a comment. In D26483#589401 , @broulik wrote: > Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? That might be able to work. @davidedmundson, co

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread David Edmundson
davidedmundson added a comment. I don't think so, as we use a runtime evaluation of kcfg files within plasma. Code tags won't work there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, b

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread David Redondo
davidre added a comment. Couldn't we just use wrap the folders from the single image case in a code tag? `QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)` REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread Kai Uwe Broulik
broulik added a comment. Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundso

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-07 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It's not ok for the reasons you identified. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, nd

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-06 Thread Nathaniel Graham
ngraham added a comment. Wondering if this is something that should be set in CMake or if it's so universal that it's okay to have it hardcoded in the file like this? REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master)

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-06 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

2020-01-06 Thread Nathaniel Graham
top > configure > change to slideshow wallpaper See `/usr/share/wallpapers` is already in the list of wallpaper locations; how nice REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL https://phabricator.kde.o

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Marco Martin
untouched does line 285 onwards. This makes me think that probably i should not define a default wallpaper in the breeze lnf, but rather in the lnf kcm when i'm re-setting the wallpaper to also look in the plasma theme if the lnf does not specify any. this way when using the breeze lnf th

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. BTW, there is also still code in place to support Plasma Themes defining a default wallpaper (or even deploy some more). Though the default & the further are not listed in the Image wallpaper config, also is the config not offering any hint about the default o

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Marco Martin
mart updated this revision to Diff 58130. mart added a comment. - use proper path of the package REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21226?vs=58127&id=58130 BRANCH mart/wallpaperFromLnf REVISION DETAIL https://phabricator.kde.org/D

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Marco Martin
mart added a comment. In D21226#465633 <https://phabricator.kde.org/D21226#465633>, @davidedmundson wrote: > Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper? layout.js is mostly to create

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread David Edmundson
davidedmundson added a comment. Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21226 To: mart, #plasma Cc: davidedmundson, p

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Marco Martin
first plasma start or at activity creation search for a default wallpaper inthe order: look and feel package if fails, from the plasma theme we are sure to find a default after it as if neither of those specify one, the wallpaper specified by the breeze plasma theme (Next) will be used

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

2019-01-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d1bc0842839: Use "Scaled and Cropped" as the default wallpaper image fill mode (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricat

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

2019-01-05 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 It works for the majority of wallpapers much better than just scaling. REPOSITORY R120 Plasma Workspace BRANCH scaled-and-cropped-by-default (branched from master) REVISION DETAIL

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

2019-01-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current default setting is "Scaled", which results in images that don't match the screen'

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

2018-12-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346251 Christoph Feck changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REPORTED

[Differential] [Closed] D2568: Unset default wallpaper in breeze SDDM

2016-08-25 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0eb474290e43: Unset default wallpaper in breeze SDDM (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Accepted] D2568: Unset default wallpaper in breeze SDDM

2016-08-25 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D2568 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Request, 2 lines] D2568: Unset default wallpaper in breeze SDDM

2016-08-24 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL h

Re: Javascript to change the default wallpaper in plasma

2016-08-18 Thread Raphael Hertzog
Hello Bushan and Marco, thanks for your answers! Le jeudi 28 juillet 2016, Bhushan Shah a écrit : > > I tried to look out for documentation but the only thing that I did > > find is this wiki page and it doesn't seem to be entirely up-to-date: > > https://userbase.kde.org/KDE_System_Administratio

[Differential] [Closed] D2352: Change default wallpaper plugin to org.kde.color

2016-08-08 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKERebd785d0ba22: Change default wallpaper plugin to org.kde.color (authored by graesslin). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Commented On] D2352: Change default wallpaper plugin to org.kde.color

2016-08-04 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2352#43900, @bshah wrote: > Perhaps we should as well define the default color used? Not sure how it would work config wise.. Ignore this, cleared up on IRC... "Ship it" from my side.. REPOSITORY rKSCREENLOCKER KScreenLocke

[Differential] [Updated, 4 lines] D2352: Change default wallpaper plugin to org.kde.color

2016-08-04 Thread Martin Gräßlin
graesslin updated this revision to Diff 5677. graesslin added a comment. Proper default also in kcm REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2352?vs=5675&id=5677 BRANCH default-wallpaper-color REVISION DETAIL h

[Differential] [Commented On] D2352: Change default wallpaper plugin to org.kde.color

2016-08-04 Thread bshah (Bhushan Shah)
bshah added a comment. Perhaps we should as well define the default color used? Not sure how it would work config wise.. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2352 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Request, 2 lines] D2352: Change default wallpaper plugin to org.kde.color

2016-08-04 Thread Martin Gräßlin
should be just a plain color, thus using color wallpaper plugin by default. TEST PLAN Locked screen, wallpaper is color REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH default-wallpaper-color REVISION DETAIL https://phabricator.kde.org/D2352 AFFECTED FILES kcfg

Re: Javascript to change the default wallpaper in plasma

2016-07-28 Thread Marco Martin
On Mon, Jul 25, 2016 at 9:01 PM, Raphael Hertzog wrote: > d = desktops() > > for (i in d) { > d[i].wallpaperPlugin = 'org.kde.image' > d[i].currentConfigGroup = Array('Wallpaper', 'org.kde.image', > 'General') > d[i].writeConfig('Image', > 'file:///

Re: Javascript to change the default wallpaper in plasma

2016-07-27 Thread Bhushan Shah
Hello Raphael On Mon, Jul 25, 2016 at 09:01:25PM +0200, Raphael Hertzog wrote: > Hello, > > I'm a Debian developer trying to fix the plasma integration with default > artwork > in Debian (https://bugs.debian.org/831730). I noticed recently that a plasma > install did not have the expected wallpa

Javascript to change the default wallpaper in plasma

2016-07-25 Thread Raphael Hertzog
Hello, I'm a Debian developer trying to fix the plasma integration with default artwork in Debian (https://bugs.debian.org/831730). I noticed recently that a plasma install did not have the expected wallpaper and thus that the existing integration no longer works. The current integration is a file

[Plasma Workspace Wallpapers] [Bug 361778] 4k default wallpaper

2016-04-15 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361778 Sebastian Kügler changed: What|Removed |Added Severity|wishlist|normal Status|UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 361778] New: 4k default wallpaper

2016-04-14 Thread CapsAdmin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361778 Bug ID: 361778 Summary: 4k default wallpaper Product: Plasma Workspace Wallpapers Version: unspecified Platform: Neon Packages OS: Linux Status: UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 346252] Default wallpaper has jagged edges

2015-04-16 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=346252 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Resolution|

[Plasma Workspace Wallpapers] [Bug 346252] Default wallpaper has jagged edges

2015-04-16 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=346252 Marco Martin changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

2015-04-16 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=346251 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com --- Comment #2 from Marco Mart

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

2015-04-16 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=346251 Jonathan Riddell changed: What|Removed |Added CC||j...@jriddell.org --- Comment #1 from Jonath

[Plasma Workspace Wallpapers] [Bug 346252] New: Default wallpaper has jagged edges

2015-04-16 Thread Vit Pelcak
https://bugs.kde.org/show_bug.cgi?id=346252 Bug ID: 346252 Summary: Default wallpaper has jagged edges Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 346251] New: Default wallpaper cannot be found in desktop settings

2015-04-16 Thread Vit Pelcak
https://bugs.kde.org/show_bug.cgi?id=346251 Bug ID: 346251 Summary: Default wallpaper cannot be found in desktop settings Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: Other OS: Linux Status

Re: [plasma-devel] Re: Default wallpaper

2015-04-09 Thread Andrew Lake
Ahhh, I see that makes sense. Thanks much, Andrew On Thu, Apr 9, 2015, 8:05 AM Marco Martin wrote: basically the idea is that in breeze there stays only one wallpaper, the default one, while the other ones, usually photos, go in plasma-workspace-wallpapers in svn so the git repo doesn't get

Re: [plasma-devel] Re: Default wallpaper

2015-04-09 Thread Marco Martin
On Thursday 09 April 2015 13:06:32 Andrew Lake wrote: > Thanks Johnathon, > > For clarity, David updated the intended 5.3 default wallpaper, Next. I > added a few more wallpapers from the wallpaper competition (not default, > but meant to be shipped). > > Hope that makes s

Re: [plasma-devel] Re: Default wallpaper

2015-04-09 Thread Andrew Lake
Thanks Johnathon, For clarity, David updated the intended 5.3 default wallpaper, Next. I added a few more wallpapers from the wallpaper competition (not default, but meant to be shipped). Hope that makes sense. Thanks again, Andrew On Thu, Apr 9, 2015, 6:00 AM Jonathan Riddell wrote: >

Re: [plasma-devel] Re: Default wallpaper

2015-04-09 Thread Jonathan Riddell
On Wed, Apr 08, 2015 at 11:25:07PM +0200, David Edmundson wrote: >this is now all sorted. These were put in breeze, I've moved them now to plasma-workspace-wallpapers in svn. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.

Re: Default wallpaper

2015-04-08 Thread David Edmundson
this is now all sorted. ​ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Default wallpaper

2015-04-08 Thread Jonathan Riddell
Hi Ken, the word on the streets is you have a new wallpaper which could be the new default. This needs to go in today as I make beta tars tomorrow for 5.3. Any plans on getting it in? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=342420 --- Comment #2 from David Edmundson --- I don't have the original assets. I could convert the JPEGs but that'd be a bit silly. Marco made the commit: "updated version of the default wallpaper from the KDE VDG" I don't know i

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake changed: What|Removed |Added CC||jamboar...@gmail.com --- Comment #1 from Andrew L

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=342420 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Status|

[Breeze] [Bug 342420] New: Provide default wallpaper in png format

2015-01-02 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=342420 Bug ID: 342420 Summary: Provide default wallpaper in png format Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity

Re: Changing the default wallpaper? WAS Re: 4.10 RC3 tarballs available for packagers

2013-01-17 Thread Marco Martin
sa Moreno va > > escriure: > > El Dijous, 17 de gener de 2013, a les 21:35:35, vau > > > > escriure: > > > The default wallpaper needs to > > > > > be changed in runtime: > > sorry, kmail sent the mail before i had time to type the > > de

Changing the default wallpaper? WAS Re: 4.10 RC3 tarballs available for packagers

2013-01-17 Thread Albert Astals Cid
Artists? Plasma guys? Albert El Dijous, 17 de gener de 2013, a les 21:37:11, Manuel Tortosa Moreno va escriure: > El Dijous, 17 de gener de 2013, a les 21:35:35, vau > > escriure: > > The default wallpaper needs to > > > be changed in runtime: > sorry, kmail sent th

Re: Setting default wallpaper with a script

2010-05-04 Thread Aaron J. Seigo
On May 4, 2010, Antony Loebs wrote: > Ok, that's good to know. I guess that raises the question, however, as to > how the wallpaper is set in the first place (currently). Is it tucked away > in the code somewhere? btw, something that i think would be Really, Really Cool(tm): * iterate over all th

Re: Setting default wallpaper with a script

2010-05-04 Thread Aaron J. Seigo
On May 4, 2010, Antony Loebs wrote: > Ok, that's good to know. I guess that raises the question, however, as to > how the wallpaper is set in the first place (currently). Is it tucked away > in the code somewhere? yes :) Containment::setWallpaper(const QString &plugin, const QString &mode) -- A

Re: Setting default wallpaper with a script

2010-05-04 Thread Antony Loebs
On Tue, May 4, 2010 at 12:38 PM, Aaron J. Seigo wrote: > the wallpaper doesn't get notified of the change; in fact, i only added any > sort of real wallpaper support in 4.5 with the wallpaperPlugin and > wallpaperMode properties for Activity objects. > > still ... what is probably needed is a way

Re: Setting default wallpaper with a script

2010-05-04 Thread Aaron J. Seigo
On May 4, 2010, Antony Loebs wrote: > So I've continued to play around with scripting the default Plasma desktop > (with JavaScript) and have a quick question: how can I set the wallpaper? I > tried the following > --- > var activity = new Activity("desktop"); > activity.currentConfigGroup = new Ar

Setting default wallpaper with a script

2010-05-04 Thread Antony Loebs
So I've continued to play around with scripting the default Plasma desktop (with JavaScript) and have a quick question: how can I set the wallpaper? I tried the following --- var activity = new Activity("desktop"); activity.currentConfigGroup = new Array("Wallpaper"); activity.writeConfig("wallpape