D9976: Display version alongside source, and use a combobox to switch between them

ngraham abandoned this revision. ngraham added a comment. Source-and-version-unification patch: https://phabricator.kde.org/D10091 Will produce a ComboBox patch if and when that's accepted, as it doesn't make as much sense without first unifying the source and version. REPOSITORY R134

D9976: Display version alongside source, and use a combobox to switch between them

ngraham added inline comments. INLINE COMMENTS > apol wrote in PackageKitResource.cpp:126 > Seems like we are hitting a bug in PackageKit-Qt here, this is not right. I filed a bug on them and they said they expect us to process the string. REPOSITORY R134 Discover Software Store REVISION DET

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg, Zren

D9976: Display version alongside source, and use a combobox to switch between them

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I think it's premature the adoption of the combo box, adding the version could make sense. INLINE COMMENTS > PackageKitResource.cpp:126 > +// PackageKit folks expect us to format

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25887. ngraham added a comment. - Merge branch 'master' into arcpatch-D9976 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9976?vs=25692&id=25887 BRANCH arcpatch-D9976 REVISION DETAIL https://phabr

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store BRANCH actually-use-combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg, Zre

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25692. ngraham added a comment. Merge master and fix the issue of "installed:" getting appended to the origin string REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9976?vs=25640&id=25692 BRANCH actua

D9976: Display version alongside source, and use a combobox to switch between them

colomar added a comment. I think that when at the bottom, having the combobox is okay because it's not too prominent. The only problem I see is that it means that changing a combobox changes the content above it, which is not usually expected behavior for a combobox. REPOSITORY R134 Disco

D9976: Display version alongside source, and use a combobox to switch between them

andreaska accepted this revision. andreaska added a comment. This revision is now accepted and ready to land. Design look good REPOSITORY R134 Discover Software Store BRANCH actually-use-combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, col

D9976: Display version alongside source, and use a combobox to switch between them

colomar added a comment. I think this is a significant improvement. I'm not sure if it's ideal to have the re-layout of the whole page together with the change to the combo box in the same patch, but that's for @apol to decide. REPOSITORY R134 Discover Software Store REVISION DETAIL h

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited reviewers, added: andreaska; removed: andreask. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg, ZrenBot, progwolff, lesliezhai, al

D9976: Display version alongside source, and use a combobox to switch between them

ngraham marked 4 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, andreask, #discover_software_store, #vdg Cc: plasma-devel, romangg, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25640. ngraham added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Make state() into const functions REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabri