D9974: Improve header and metadata display

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andre

D9974: Improve header and metadata display

This revision was automatically updated to reflect the committed changes. Closed by commit R134:93bd781900b5: Improve header and metadata display (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25665&id=25668 REVI

D9974: Improve header and metadata display

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: matheu

D9974: Improve header and metadata display

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: matheusm, andreaska, januz, romangg, plasma-devel, ZrenBot, progwolff, leslie

D9974: Improve header and metadata display

ngraham updated this revision to Diff 25665. ngraham added a comment. Removed the "Details" header text to prevent string changes so this can go into 5.12 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25664&id=25665 BRANCH combo

D9974: Improve header and metadata display

ngraham updated this revision to Diff 25664. ngraham added a comment. Re-add logic for handling source switcher in description that was mistakenly removed REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25620&id=25664 BRANCH combo

D9974: Improve header and metadata display

matheusm added a comment. What about removing the application name from the header, to avoid redundancy? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: matheusm, a

D9974: Improve header and metadata display

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:227 > This is a new string. Can't have new strings for 5.12. Aww darn. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover

D9974: Improve header and metadata display

apol requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: andreaska, januz, romangg, plasm

D9974: Improve header and metadata display

apol added a comment. I like it, some nitpicking: F5664327: Screenshot_20180119_204906.png This is the application delegate, I think it would make sense to do the same use of the blue line that is here. Also I would remove the blue line under De

D9974: Improve header and metadata display

colomar accepted this revision. colomar added a comment. This is a clear improvement from my perspective, and I don't see it introducing any usability issues. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To

D9974: Improve header and metadata display

ngraham removed a reviewer: andreask. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: andreaska, januz, romangg, plasma-devel, ZrenB

D9974: Improve header and metadata display

andreaska accepted this revision. andreaska added a comment. This revision is now accepted and ready to land. Big improvement from design and usability. Top the app information and bottom tecnical stuff REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DE

D9974: Improve header and metadata display

januz added a comment. +1 Looks way more organized, and it's easier to grasp what application you're seeing and what it does on a quick glance. Minor nitpick: I'd add more margin around the summary text (to separate it better from screenshots and the summary link). REPOSITORY R134 Discove

D9974: Improve header and metadata display

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: romangg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D9974: Improve header and metadata display

ngraham added a comment. Thanks for the vote of confidence, Roman! In this patch, I didn't touch the review UI; it's still a pop-up. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software

D9974: Improve header and metadata display

romangg added a comment. In my opinion this looks absolutely wonderful! When we last discussed Discover app pages in VDG Telegram channel I said that the version selection should be at top together with the other basic information, but by this I meant foremost that the info should be tog

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham added a dependent revision: D9976: Display version alongside source, and use a combobox to switch between them. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc:

D9974: Improve header and metadata display

ngraham retitled this revision from "Improve header, metadata display, and version chooser UI" to "Improve header and metadata display". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https: