mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9764#188910, @davidedmundson wrote:
> > maybe one could still work around by connecting blindly to that by hand
>
> There's nothing inherently wrong with doing that
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
mart/tabletMode
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin, graesslin
Cc: grae
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
> maybe one could still work around by connecting blindly to that by hand
There's nothing inherently wrong with doing that. Assuming the DBus API is
stable is as valid and as easy as assumi
mart marked 2 inline comments as done.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, ZrenBot, progwolff,
lesliezhai
mart updated this revision to Diff 25099.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
adress comments
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9764?vs=25022&id=25099
BRANCH
mart/tabletMode
REVISION DETAIL
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9764#188872, @graesslin wrote:
> In https://phabricator.kde.org/D9764#188862, @mart wrote:
>
> > In https://phabricator.kde.org/D9764#188354, @graesslin wrote:
>
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9764#188862, @mart wrote:
> In https://phabricator.kde.org/D9764#188354, @graesslin wrote:
>
> > In https://phabricator.kde.org/D9764#188268, @mart wrote:
>
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9764#188354, @graesslin wrote:
> In https://phabricator.kde.org/D9764#188268, @mart wrote:
>
> > one thing i'm wondering, is how to manage dependencies, as ideally
graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> tabletmodemanager.cpp:75
> +{
> +m_spy = new TabletModeInputEventSpy(this);
> +input()->installInputEventSpy(m_spy);
please put into initializer.
Also the spy leaks.
>
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9764#188268, @mart wrote:
> one thing i'm wondering, is how to manage dependencies, as ideally we want
most of our apps to make use of this, but can't ask for sur
mart edited the test plan for this revision.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin
Cc: davidedmundson, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot,
progwolff,
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
one thing i'm wondering, is how to manage dependencies, as ideally we want
most of our apps to make use of this, but can't ask for sure to depend from
kwin..., which finding the xml would make it an hard
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
DBus code is all good.
It would be nice if you can run qdbuscpp2xml on the TabletModeManager and
install that .xml file in /usr/share/dbus-1/services it will allow other
programs to ge
mart added reviewers: Plasma, KWin.
Restricted Application edited projects, added Plasma; removed KWin.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin
Cc: plasma-devel, kwin, #kwin, Zren
14 matches
Mail list logo
