fvogt updated this revision to Diff 24921.
fvogt added a comment.
Address review comments.
Set a unified alpha for percentage marker and history graph to avoid sudden
changes:
33%: Percentage marker
66%: History graph
100%: Text
Screenshot is linked in the test plan.
REPOSITOR
broulik added a comment.
Screenshot? :)
INLINE COMMENTS
> ProcessModel.cpp:804
> + * didn't change though. */
> +if(mMapProcessCPUHistory.contains(process)) {
> +auto &history = mMapProcessCPUHistory[process];
Use `find()` to avoid double lookup (contains+operator
fvogt updated this revision to Diff 24838.
fvogt added a comment.
Forgot to save ProcessModel.cpp before git commit.
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=24836&id=24838
BRANCH
history
REVISION DETAIL
https://phabricator.kde
fvogt updated this revision to Diff 24836.
fvogt added a comment.
Instead of updating the last entry's timestamp if the value is the same, add
a new
entry only if the latest entry has a certain age.
Otherwise, the interpolation results would look differently and processes had
different
fvogt updated this revision to Diff 24804.
fvogt added a comment.
Remove the history tail before appending the head to never exceed the
reserved vector size
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=24803&id=24804
BRANCH
history
fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.
REVISION SUMMARY
By adding a new PercentageHistoryRole returning a QVector with timestamps and
values, the delegate can show the history of the
