D9643: Support submenus in context menu for systray icon

2018-01-08 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D9643: Support submenus in context menu for systray icon

2018-01-08 Thread Alexander Volkov
volkov added a comment. Thanks for the real-world example. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progw

D9643: Support submenus in context menu for systray icon

2018-01-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, pla

D9643: Support submenus in context menu for systray icon

2018-01-05 Thread Kai Uwe Broulik
broulik added a comment. +1 I can verify that it makes VLC player's "Speed" sub menu in its tray icon work, checked that Qt's code is identical. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graessli

D9643: Support submenus in context menu for systray icon

2018-01-03 Thread David Edmundson
davidedmundson added a comment. Please fill in the "testing done" field. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9643: Support submenus in context menu for systray icon

2018-01-03 Thread David Edmundson
davidedmundson added a comment. > Why don't rely on QDBusTrayIcon? It's internal to Qt. We could fork it like we did with the application menu, but then that's no easier than maintaining our current code. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D9643: Support submenus in context menu for systray icon

2018-01-03 Thread Alexander Volkov
volkov added a comment. BTW, why do we need to support KDEPlatformSystemTrayIcon? Why don't rely on QDBusTrayIcon? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwo

D9643: Support submenus in context menu for systray icon

2018-01-03 Thread Alexander Volkov
volkov added reviewers: Plasma, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart