D9478: Drop use of qtpaths in startkde

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R120:fd7d1ca3d705: Drop use of qtpaths in startkde (authored by davidedmund

D9478: Drop use of qtpaths in startkde

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in startplasmacompositor.cmake:174 > Why is `|| true` needed now? it's syncing startkde with the wayland one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D9478: Drop use of qtpaths in startkde

apol added a comment. Other than that, it looks good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9478 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9478: Drop use of qtpaths in startkde

apol added inline comments. INLINE COMMENTS > startplasmacompositor.cmake:174 > + for file in "$prefix"/plasma-workspace/env/*.sh; do > +test -r "$file" && . "$file" || true >done Why is `|| true` needed now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D9478: Drop use of qtpaths in startkde

davidedmundson updated this revision to Diff 24712. davidedmundson added a comment. Update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9478?vs=24293&id=24712 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9478 AFFECTED FILES

D9478: Drop use of qtpaths in startkde

apol added inline comments. INLINE COMMENTS > apol wrote in startkde.cmake:41 > `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}` > > As we did for https://phabricator.kde.org/D9299 No, with this you get to remove the if altogether. > startplasmacompositor.cmake:24 > fi > +if [ ${XDG_CONFIG_DIRS}

D9478: Drop use of qtpaths in startkde

davidedmundson updated this revision to Diff 24293. davidedmundson added a comment. Update with Aleix's change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9478?vs=24292&id=24293 BRANCH master REVISION DETAIL https://phabricator.kde.org/D94

D9478: Drop use of qtpaths in startkde

apol added a comment. Thanks for looking into this! INLINE COMMENTS > startkde.cmake:41 > fi > +if [ ${XDG_CONFIG_DIRS} ]; then > +sysConfigDirs=$XDG_CONFIG_DIRS `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}` As we did for https://phabricator.kde.org/D9299 REPOSITORY R120 Plasma Works

D9478: Drop use of qtpaths in startkde

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qtpaths doesn't work on some distros (Ubuntu for example, where it's shipped with dev tools)