apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Go for it then, good riddance of that code. :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9460
To: dvratil, sebas, davidedmundson, apol
Cc: apol, plasma-devel, Zr
dvratil added a comment.
In https://phabricator.kde.org/D9460#182151, @apol wrote:
> In https://phabricator.kde.org/D9460#182139, @dvratil wrote:
>
> > QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
>
>
> Not if it's within `_transfor
apol added a comment.
In https://phabricator.kde.org/D9460#182139, @dvratil wrote:
> QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
Not if it's within `_transformedSize()`
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricato
dvratil added a comment.
QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9460
To: dvratil, sebas, davidedmundson
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m
apol added inline comments.
INLINE COMMENTS
> Output.qml:46
> +
> +width: _transformedSize(monitorMouseArea).width
> +height: _transformedSize(monitorMouseArea).height
If you pass item.rotation as an argument, qml will pick up the change
automatically. Can't rotation change?
REPOSITORY
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Removes the need for calling QMLOutput::updateRootProperties() from
arbitrary places. This wa
