D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-22 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0f3fd179c9e8: Port plasma-integration to explicit wayland AppMenu protocol (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https:/

D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-08 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9248 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwol

D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-08 Thread Martin Flöser
graesslin added a comment. I'm not really used to being addressed as Martin F. yet - I just realized. I see pro and cons for both. Personally I think it is better to have destinct interfaces for different functionality. It's easier for the case that someone else wants to reuse this. And

D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-08 Thread David Edmundson
davidedmundson updated this revision to Diff 23657. davidedmundson added a comment. Fix a hypothetical case of the manager not existing and the QPT being used REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9248?vs=23637&id=

D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-08 Thread David Edmundson
davidedmundson added a comment. Martin F: One idea suggested was to use the same interface for all generic window -> kwin specific things and move the server side palette into the same interface. It'd mean a few renames, but be a lot less work overall, particularly when we want to add n

D9248: Port plasma-integration to explicit wayland AppMenu protocol

2017-12-08 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also fixed to handle the case of surfaces not having the lifespan of the window, which the ol