D9194: Don't load KDE platform module in xembedsniproxy

2017-12-05 Thread Eike Hein
hein updated this revision to Diff 23493. hein added a comment. Remove David's line. That one can't work because the app's already been instantiated then. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9194?vs=23484&id=23493 BRANCH master

D9194: Don't load KDE platform module in xembedsniproxy

2017-12-05 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:23c30cfba92d: Don't load KDE platform module in xembedsniproxy (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9194?vs=23493&id=23494 R

D9194: Don't load KDE platform module in xembedsniproxy

2017-12-05 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. please remove the useless line. Ideally without running git blame first. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/

D9194: Don't load KDE platform module in xembedsniproxy

2017-12-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.cpp:59 > > app.setDesktopSettingsAware(false); > app.setQuitOnLastWindowClosed(false); It was clearly meant to be :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9194 To: hein, #plasma, davi

D9194: Don't load KDE platform module in xembedsniproxy

2017-12-05 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY xembedsniproxy doesn't do anything that requires it to be aware of KDE GUI settings (colors, style, standard keys, etc). This makes it start a fair bi