This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a715a6cd1fe3: Add support for version 3 of data device
manager interface (authored by graesslin).
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
CHANGED PRIOR TO COMMI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REPOSITORY
R127 KWayland
BRANCH
data-device-version-3
REVISION DETAIL
https://phabricator.kde.org/D9136
To: graesslin, #
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D9136
To: graesslin, #frameworks, #plasma, #kwin
Cc: ngraham, broulik, plasma-devel, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-mo
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
INLINE COMMENTS
> broulik wrote in datadevicemanager.h:74
> Should `Ask` perhaps become a bigger number in case stuff gets added in the
> middle later like `Link` or is that unlikel
broulik added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
lgtm
INLINE COMMENTS
> datadevice.cpp:177
> {
> +if (d->drag.offer) {
> +delete d->drag.offer;
`delete nullptr` is just fine
> datadevicemanager.h:74
> +Move = 1 <<
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D9136
To: graesslin, #frameworks, #plasma, #kwin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh
graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma, KWin.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The main difference compared to version 2 is additional drag and d
