D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Eike Hein
hein added a comment. I accidentally pushed this, but given Kai's earlier comment I think this was OK. Please double-check if necessary. It's not my day with command line tools I think :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9122 To: hein, #p

D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1a45aaf94893: Implement QQmlParserStatus in FolderModel (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9122?vs=23323&id=23385 REVISION D

D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Eike Hein
hein updated this revision to Diff 23323. hein added a comment. Add interface REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9122?vs=23321&id=23323 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9122 AFFECTED FILES containments/d

D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Kai Uwe Broulik
broulik added a comment. +1 INLINE COMMENTS > foldermodel.h:79 > { > Q_OBJECT > Add `Q_INTERFACES(QQmlParserStatus)` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9122 To: hein, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, al

D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Eike Hein
hein updated this revision to Diff 23321. hein added a comment. Remove a stray qDebug line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9122?vs=23320&id=23321 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9122 AFFECTED FILES

D9122: Implement QQmlParserStatus in FolderModel

2017-12-03 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. REVISION SUMMARY This saves four calls to `invalidateFilter()` during startup with default config. With non-default config it will save various calls to `invalidate()` and `inva