D9109: Performance

2017-12-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1f9b5ed657df: Performance (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9109?vs=23283&id=23285 REVISION DETAIL https://pha

D9109: Performance

2017-12-02 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9109 To: apol, #frameworks, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed

D9109: Performance

2017-12-02 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 23283. apol added a comment. Remove crazy check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9109?vs=23282&id=23283 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9109 AFFECTED FILES

D9109: Performance

2017-12-02 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > packageurlinterceptor.cpp:166 > +const int firstSlash = relativePath.indexOf(QLatin1Char('/')); > +const QString filename = firstSlash >= 0 && firstSlash < > relativePath.size() ? relativePath.mid(firstSlash + 1) : relativePath; > +

D9109: Performance

2017-12-02 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove splitting + joining of a string just to remove the beginning of a string. Remove d