This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b6b81c67b310: Use setSize() instead of setProperty width
and height (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9068?vs
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I'm sure we'd done this already...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9068
To: broulik, #plasma, davidedmundson
Cc: davidedmu
broulik updated this revision to Diff 23173.
broulik added a comment.
- Restore accidentally removed comment
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9068?vs=23171&id=23173
REVISION DETAIL
https://phabricator.kde.org/D9068
AFFECTED FILES
broulik added a comment.
> I'm sure we'd done this already...
I replaced all method calls to `setWidth()` and `setHeight()` but not
instances where we went through `setProperty`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9068
To: broulik, #plasma,
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We know we have a `QQuickItem` so we can just use its methods directly and
then also u
