This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a0180f387eaf: Add explicit AppMenu protocol (authored by
davidedmundson).
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
CHANGED PRIOR TO COMMIT
https://phabricator.
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8919
To: davidedmundson, #plasma, graessl
davidedmundson updated this revision to Diff 23083.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Add line in docs
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8919?vs=22890&id=23083
BRA
graesslin added inline comments.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
INLINE COMMENTS
> appmenu.xml:37-38
> +
> +
> +
> +
Could you please add "The string must be encoded in latin-1".
REPOSITORY
R127 KWayland
R
davidedmundson updated this revision to Diff 22890.
davidedmundson marked 8 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Docs++
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricat
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in appmenu.cpp:178
> Wayland strings can be UTF-8 but DBus service names and object paths can only
> be ASCII.
>
> I figured it was best to avoid any potential locale issues.
Fair enough. I wasn't aware of the DBus restric
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in appmenu.cpp:178
> why toLatin1? I would expect a toUtf8?
Wayland strings can be UTF-8 but DBus service names and object paths can only
be ASCII.
I figured it was best to avoid any potential locale issues.
> graesslin w
broulik added a comment.
lgtm
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8919
To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas,
graesslin added a comment.
Looks good, just a few minor comments.
INLINE COMMENTS
> appmenu.cpp:178
> +Q_ASSERT(isValid());
> +org_kde_kwin_appmenu_set_address(d->appmenu, serviceName.toLatin1(),
> objectPath.toLatin1());
> +}
why toLatin1? I would expect a toUtf8?
> appmenu.xml:6-
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
A protocol that attaches to a surface and contains two strings
10 matches
Mail list logo
