This revision was automatically updated to reflect the committed changes.
Closed by commit R134:732a0ffb2ab0: Don't use a scrollview to display
package changelogs (authored by ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8869?vs=225
apol accepted this revision.
apol added a comment.
Go for it, master branch.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesli
ngraham added a comment.
@apol Thanks! I made one more change (the text of the "Info") button; does
your approval still hold?
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: abetts
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: abetts, broulik, plasma-devel, ZrenBot, prog
ngraham updated this revision to Diff 22533.
ngraham added a comment.
Also change "Open" button to say "More Information..." (it's not clear what
you were opening before)
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8869?vs=22532&id=22533
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Okay, let's give it a try and see where this takes us.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_sof
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol,
ngraham updated this revision to Diff 22532.
ngraham added a comment.
Add a frame around the text if the box is extended
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8869?vs=22528&id=22532
BRANCH
master
REVISION DETAIL
https://phabri
ngraham updated this revision to Diff 22528.
ngraham added a comment.
Updating diff
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8869?vs=22526&id=22528
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8869
AFFECTED FILES
ngraham added a comment.
IMHO the open button is superfluous for package updates anyway. It takes you
to a view that doesn't even show you the changelogs.
Perhaps what we should do is the following:
- Get rid of the Open button
- Make clicking on the package take you to the view th
abetts added a comment.
What's the point of having the "open" button if this scrollview is accepted?
After all, you won't see much more if you click open and an install button and
a package description.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/
ngraham added a comment.
If the changelog is like a thousand lines long, you can always just close it
again. And I think it would actually be easier to read as one huge box than a
tiny scrollview that only shows like 5 lines at a time.
Another option would be that clicking on a package t
apol added a comment.
Won't this introduce other usability issues? :/
WRT the patch, it's fine, just remove the RowLayout and put its properties
into the label
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_
broulik added a comment.
Can't the changelog become utterly long? Perhaps a popup/overlay sheet thing
would be more appropriate
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: broulik, plasma-devel
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham added reviewers: Discover Software Store, apol.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D8869
To: ngraham, #discover_software_store, apol
Cc: plasm
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 387036
Don't put the package changelogs in a scrollview, because it introduces some
usability issues (see the bug for details)
TEST
16 matches
Mail list logo
