broulik abandoned this revision.
broulik added a comment.
https://phabricator.kde.org/D8851 gives virtually the same benefit without
having to adjust the applications themselves
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8845
To: broulik, mart
Cc: david
graesslin added a comment.
In https://phabricator.kde.org/D8845#168632, @broulik wrote:
> Look in the constructor, kept it consistent
ah I just made this as a proposal as you had to change unrelated lines.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kd
broulik added a comment.
Look in the constructor, kept it consistent
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8845
To: broulik, mart
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
I think you've identified something, (well, 0.2% on my PC) , which is good,
but I think we should delve deeper into the issue.
KTooltipManager isn't slow, it's the platform window being created in
KTooltipWidget constructor that is.
We can just move that
graesslin added inline comments.
INLINE COMMENTS
> SidebarMode.cpp:236
>
> ToolTipManager *toolTipManager;
> QQuickWidget * quickWidget;
toolTipManager = nullptr;
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8845
To: broulik, mart
Cc: graesslin,
broulik created this revision.
broulik added a reviewer: mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It takes a couple of milliseconds to be created and isn't vital for System
Settings startup.
TEST PLAN
Tool
