D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-12-26 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e0b1a5715bd7: Add DBus interface to OrientationSensor and a persistent configuration (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. CHANGED PRIOR TO COMMIT

D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-12-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH orientation-sensor-dbus REVISION DETAIL https://phabricator.kde.org/D8738 To: graesslin, #kwin, #plasma,

D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-12-05 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8738 To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: anthonyfieroni, plasma-devel, kwin, ZrenBot, progwolff, lesl

D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-11-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in orientation_sensor.cpp:106 > m_userEnabled = m_config && > m_config->group("OrientationSensor").readEntry("Enabled", true); > > ? I might want to extend the loadConfig with further options (who knows) and then it wou

D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-11-09 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > orientation_sensor.cpp:106 > +} > +m_userEnabled = > m_config->group("OrientationSensor").readEntry("Enabled", true); > +} m_userEnabled = m_config && m_config->group("OrientationSensor").readEntry("Enabled", true); ? REPOSITORY

D8738: Add DBus interface to OrientationSensor and a persistent configuration

2017-11-09 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, sebas, davidedmundson. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The initial state for user enabled is now read from config. In addition