D8652: Add supported transformations to OutputDevice

2018-01-19 Thread Sebastian Kügler
sebas added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Dingdong? REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas, davidedmunds

D8652: Add supported transformations to OutputDevice

2017-12-06 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. In https://phabricator.kde.org/D8652#176706, @davidedmundson wrote: > The comment about being static needs to be in the protocol xml too. Then this is good to go. > > ( though w

D8652: Add supported transformations to OutputDevice

2017-12-06 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. The comment about being static needs to be in the protocol xml too. Then this is good to go. ( though what's your reasoning for not just

D8652: Add supported transformations to OutputDevice

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > outputdevice.h:244 > + * @returns The transformations supported on this OutputDevice > + * @since 5.XX > + * @see supportedTransformationAdded 5.40 I guess :)

D8652: Add supported transformations to OutputDevice

2017-11-04 Thread Martin Flöser
graesslin updated this revision to Diff 21872. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. enum and uint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8652?vs=21869&id=21872 BRANCH support

D8652: Add supported transformations to OutputDevice

2017-11-04 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:470 > we have the initial send which is all fine > > Then you've got this dynamically add them. > But at a protocol level we have no way to remove and replace. > That's somewhat broken. > > Per

D8652: Add supported transformations to OutputDevice

2017-11-04 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > outputdevice.xml:225 > + > + > + enum="transform" also uint > outputdevice_interface.cpp:470 > > +void OutputDeviceInterface::addSupportedTransformation(Transform > transformation) > +{ we have the initial send whic

D8652: Add supported transformations to OutputDevice

2017-11-04 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The server can announce all supported transformations on an Output