This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6e1ae0539c4e: Fix crash in KAStatsFavouritesModel
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8608?vs=22111&id=22257#toc
REPOSITORY
R119 Plasma Desktop
CHAN
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8608
To: davidedmundson, #plasma, hein
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
je
davidedmundson updated this revision to Diff 22111.
davidedmundson marked 4 inline comments as done.
davidedmundson added a comment.
Update
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8608?vs=21739&id=22111
BRANCH
master
REVISION DETAIL
http
anthonyfieroni added inline comments.
INLINE COMMENTS
> kastatsfavoritesmodel.cpp:506
> {
> return d->trigger(row, actionId, argument);
> }
d && d->trigger ?
> kastatsfavoritesmodel.cpp:622
> {
> const auto url = d->normalizedId(id).value();
>
addFavorite has a check, so here it
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
of the KAStatsFavourit
