mwolff abandoned this revision.
mwolff added a comment.
oh of course, the dropJob is the sender, stupid me.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: hein, ngraham, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff,
hein added a comment.
It's not necessary to delete connections. When a QObject is destroyed this is
done already. Patch rejected sorry :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: hein, ngraham, broulik, anthonyfieroni, plas
broulik added a comment.
This looks fishy. From `QObject::connect()` docs:
> The connection will automatically disconnect if the sender or the context
is destroyed.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: broulik, ant
anthonyfieroni added a comment.
Are sure about that? Every connection is destroyed when sender or receiver
dies i.e. when dropjob dies connection also, no?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: anthonyfieroni, plasma-dev
anthonyfieroni added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When handling a drop event, a drop job was created and a
Qt signal/slot connection created. This connection was only
freed once the model ge
