This revision was automatically updated to reflect the committed changes.
Closed by commit R108:77b5c3caa953: [platforms/drm] Add support for rotation
property on the Plane (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8582?vs=21667&id=2
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
drm-plane-rotate
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, kwin, bw
graesslin added a dependent revision: D8627: [platforms/drm] Properly adjust
cursor position on a rotated output.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: ngraham, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, pr
graesslin added a dependent revision: D8602: [platforms/drm] Restore previous
mode if an atomic test fails.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, leslie
graesslin added a dependent revision: D8594: [platforms/drm] Rotate screen if
requested from KScreen.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin added a comment.
In https://phabricator.kde.org/D8582#162577, @davidedmundson wrote:
> Do you think we'll need a compositor fallback?
>
> *If* we do have a compositor fallback, then I don't see the point of a DRM
specific codepath, it's not going to have any slower having a
davidedmundson added a comment.
Do you think we'll need a compositor fallback?
*If* we do have a compositor fallback, then I don't see the point of a DRM
specific codepath, it's not going to have any slower having a transform in
painting, and will just result in one code path not getting
graesslin updated this revision to Diff 21667.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Call it "Transformation" instead of "Rotation" and make it proper flags.
After further reading I noticed one needs to combine the flipped and rotate
graesslin updated this revision to Diff 21666.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Incorporate suggested changes
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8582?vs=21659&id=21666
BRANCH
drm-plan
subdiff added inline comments.
INLINE COMMENTS
> drm_object_plane.cpp:125
> +{
> +if (m_rotation == r) {
> +return;
Check not necessary.
> drm_object_plane.h:107
> uint32_t m_possibleCrtcs;
> +Rotation m_rotation = Rotation::Rotate0;
> };
I wouldn't add an additional vari
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
A preparation step to support rotation of outputs. The idea is to rotate
using DRM dir
11 matches
Mail list logo
