D8566: Add API to retrieve the screen id for a screen name

2017-11-14 Thread Andras Mantia
This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab03787350a: Add signals indicating if a screen was added or removed (authored by amantia). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8566?

D8566: Add API to retrieve the screen id for a screen name

2017-11-02 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson Cc: broulik, plasma-devel, dhauman

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread Andras Mantia
amantia added a dependent revision: D8493: Make Folder View screen aware. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson Cc: broulik, plasma-devel, dhaumann, apol, #frameworks,

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot, progwolff, lesliezhai, al

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread Andras Mantia
amantia updated this revision to Diff 21682. amantia added a comment. Add signals instead of a new virtual method (that is not BIC). This also makes us not rely on screen name, but only on plasma-internal screen id. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE htt

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread Andras Mantia
amantia added a comment. @broulik Very good point, luckily I reworked it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot, pro

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread Kai Uwe Broulik
broulik added a comment. This class is exported, you cannot add a new virtual to it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, Z

D8566: Add API to retrieve the screen id for a screen name

2017-11-01 Thread Andras Mantia
amantia updated this revision to Diff 21679. amantia added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fix API docs text REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org