This revision was automatically updated to reflect the committed changes.
Closed by commit R120:da91a5224e48: Add a signal notifying a change in the
names of running activities. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8524?v
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma, davidedmundson
Cc: davidedmundson, anthonyfieroni, ivan, plasma-devel, ZrenBot, progw
hein added a comment.
Such a class would imho be pretty redundant to the model class, so now it's
back to whether David wants to accept this patch or not.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma, davidedmundson
Cc: davidedmund
ivan added a comment.
The activities cache is a private class meant to communicate directly to
KAMD. The signals it contains are in the form `(activity id, something)` and
are meant to be private. The `KActivities::Info` class was meant to wrap these
signals into a nice OO API where an activ
hein added a comment.
Looking at the KActivities API more, perhaps not exposing this directly was
deliberate of Ivan as otherwise Consumer would probably have all of the Cache
signals. Ivan, can you opine on this?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.
hein added a comment.
I inquired upstream about a signal/API a few times and wasn't told about this
signal. I will look into it, unless Ivan wants to.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma, davidedmundson
Cc: davidedmundson,
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
ActivitiesCache has a perfectly good nameChanged signal which is exactly what
we want.
I know it's not currently public API, but we should be fixing things
pr
hein added a comment.
Ping
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma
Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
hein added a comment.
Please re-review, my above comment and diff update were submitted together.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma
Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jen
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in activityinfo.cpp:81-86
> They should emit also numberOfRunnigActivitiesChanges, no?
They don't need to. It's emitted in response to
&KActivities::Consumer::runningActivitiesChanged.
Actually, doing the reverse might make mor
hein updated this revision to Diff 22084.
hein added a comment.
Don't connect too rowsInserted/rowsRemoved.
This is already handled by connecting to
KActivities::Consumer::runningActivitiesChanged.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
anthonyfieroni added inline comments.
INLINE COMMENTS
> activityinfo.cpp:81-86
> +connect(d->activitiesModel, &KActivities::ActivitiesModel::rowsInserted,
> +this, &ActivityInfo::namesOfRunningActivitiesChanged);
> +connect(d->activitiesModel, &KActivities::ActivitiesModel::rowsRe
hein added a comment.
ping?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma
Cc: ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
hein updated this revision to Diff 21544.
hein added a comment.
Also handle empty roles.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8524?vs=21438&id=21544
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8524
AFFECTED FILES
l
hein added a comment.
In https://phabricator.kde.org/D8524#161438, @ivan wrote:
> Also, not sure adding a signal that has one user only to a shared library
is the best approach, especially since .h says this:
>
> 37 * @NOTE: This is a placeholder, to be moved into KActivities (whic
ivan added a comment.
Also, not sure adding a signal that has one user only to a shared library is
the best approach, especially since .h says this:
37 * @NOTE: This is a placeholder, to be moved into KActivities (which it
38 * wraps) or the Task Manager applet backend.
hein added a dependent revision: D8525: Refresh when the names of the running
activities change..
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8524
To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seba
hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
REVISION SUMMARY
CCBUG:384001
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8524
AFFECTED FILES
libtaskmanager/activityinfo.cpp
l
18 matches
Mail list logo
