D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=22463&id=22464 REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #framewo

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread Marco Martin
mart updated this revision to Diff 22463. mart added a comment. - guard null REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21440&id=22463 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES src/kcmoduleqml.

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread Marco Martin
mart marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:154 > can this be null? Quick glance at `QQuickItemPrivate::nextPrevItemInTabFocusChain` shows it cannot. In doubt it returns `this`. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.o

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleqml.cpp:143 > +{ > +//FIXME: those are all workarounds around the QQuickWidget brokeness > +if (watched == d->quickWidget && ev

D8522: keyboard navigation in and out QML kcms

2017-11-16 Thread Marco Martin
mart added a comment. ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8522: keyboard navigation in and out QML kcms

2017-10-27 Thread Marco Martin
mart updated this revision to Diff 21440. mart added a comment. - skip widgets that don't accept focus REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21435&id=21440 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTE

D8522: keyboard navigation in and out QML kcms

2017-10-27 Thread Marco Martin
mart added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8522: keyboard navigation in and out QML kcms

2017-10-27 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QQuickWidget doesn't support keyboard navigation per se, the widget will gain keyboard focu