D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Алексей Шилин
aleksejshilin added a comment. @broulik @ngraham Many thanks! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Kai Uwe Broulik
broulik added a comment. Thanks for taking care of this! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R122:692bb264a812: Fix brightness not restoring when an inhibition is active (authored by aleksejshilin, committed by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.

D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Nathaniel Graham
ngraham added a comment. Lovely work. I can land this for you. REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohame

D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D8502: Fix brightness not restoring when an inhibition is active

2017-10-27 Thread Алексей Шилин
aleksejshilin added a comment. In https://phabricator.kde.org/D8502#160618, @broulik wrote: > I bet there's a bug report on Bugzilla about this. Yeah, 352497 looks like it. There are also a few suspects: 351693 and 358588 (but they say 'Reproducible: Always'), 357621 (not sur

D8502: Fix brightness not restoring when an inhibition is active

2017-10-26 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Wow. Good observation! I bet there's a bug report on Bugzilla about this. Do you have commit access? REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL h

D8502: Fix brightness not restoring when an inhibition is active

2017-10-26 Thread Алексей Шилин
aleksejshilin added a comment. I've created a script to demonstrate the issue (attached). It uses VLC to acquire inhibition after the screen is dimmed. Usage: ./test_restore_brightness.sh F5451108: test_restore_brightness.sh REPOSITORY R122 Power

D8502: Fix brightness not restoring when an inhibition is active

2017-10-26 Thread Алексей Шилин
aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY An active inhibition with ChangeScreenSettings policy won't allow to restore dimmed screen brig