This revision was automatically updated to reflect the committed changes.
Closed by commit R119:40f8edd70f4a: Refactor kcm_input to enable having
multiple backends. (authored by xuetianweng).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8460?vs=21675&
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Works great for me. Nice work, I can't wait to see this whole thing finished
and get proper libinput support.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://
xuetianweng reclaimed this revision.
xuetianweng added a comment.
.. Sorry click on the wrong one.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8460
To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
xuetianweng abandoned this revision.
xuetianweng added a comment.
To be split into small patches.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8460
To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
xuetianweng added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8460
To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
xuetianweng added a comment.
In https://phabricator.kde.org/D8460#161613, @subdiff wrote:
> In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote:
>
> > Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will
only
> > get a virtual cursor. Thus I just move
xuetianweng updated this revision to Diff 21675.
xuetianweng marked 8 inline comments as done.
xuetianweng added a comment.
Remove backend check so xwayland settings may be changed.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8460?vs=21674&id=2167
xuetianweng added inline comments.
INLINE COMMENTS
> subdiff wrote in mousebackend.h:26
> Put this enum class in a separate file, such that you don't have to include
> the full mousebackend.h in other header files like mouse.h
I guess I can put it in mousesettings.h ..
> subdiff wrote in mouse
xuetianweng updated this revision to Diff 21674.
xuetianweng marked 11 inline comments as done.
xuetianweng added a comment.
update based on comments.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8460?vs=21404&id=21674
BRANCH
master
REVISION DE
subdiff added a comment.
In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote:
> Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only
> get a virtual cursor. Thus I just move the condition to check the name of
qpa
> platform for now.
Can you
subdiff added inline comments.
INLINE COMMENTS
> x11mousebackend.cpp:26
> +#include
> +#include
> +#include
This include is not needed.
> x11mousebackend.cpp:42
> +static const char PROFILE_ADAPTIVE[] = I18N_NOOP("Adaptive");
> +static const char PROFILE_FLAT[] = I18N_NOOP("Flat");
> +
Thes
xuetianweng updated this revision to Diff 21404.
xuetianweng added a comment.
Update accroding to subdiff's comment.
Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only
get a virtual cursor. Thus I just move the condition to check the name of qpa
platform for no
subdiff added a comment.
A kapplymousetheme binary is for sure only needed in the context of X. I
would therefore not write it by the tools of the backend plugin system, but
leave it as it is and put it in the X11 backend directory (and put its cmake
code into the X11 cmake file). That will
xuetianweng created this revision.
xuetianweng added reviewers: subdiff, davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Split patch for https://phabricator.kde.org/D8168. This change only refactor
14 matches
Mail list logo
