This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c2cf81f26bfe: Dict Engine: improve error handling.
(authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8419?vs=21116&id=21215#toc
REPOSITORY
R120 Plasma Workspace
CHANGES S
dfaure added a comment.
In https://phabricator.kde.org/D8419#158645, @broulik wrote:
> Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define?
Well spotted. The Messages.sh file was there, but not the define. Fixed and
pushed.
REPOSITORY
R120 Plasma Workspace
BRAN
broulik added a comment.
Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define?
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8419
To: dfaure, #plasma, davidedmundson
Cc: broulik, plasma-devel, #plasma, ZrenBot, progwolf
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8419
To: dfaure, #plasma, davidedmundson
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-
dfaure created this revision.
dfaure added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of returning "\n\n"
when the word doesn't exist, return a proper readable string so users
know that
