This revision was automatically updated to reflect the committed changes.
kfunk marked an inline comment as done.
Closed by commit R871:abb6999b736b: Modernize: Use nullptr where possible
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8309?vs=20789&id=20800#toc
REPOS
kfunk marked an inline comment as done.
kfunk added inline comments.
INLINE COMMENTS
> broulik wrote in backtracegenerator.cpp:69
> `Q_ASSERT(!m_proc && !m_temp)`?
> iirc Clang doesn't like comparisons to `nullptr` very much (at least in
> `QCOMPARE`) and I find it cleaner
That can't be problem
sitter accepted this revision.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8309
To: kfunk, sitter, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> backtracegenerator.cpp:69
> //they should always be null before entering this function.
> -Q_ASSERT(m_proc == NULL && m_temp == NULL);
> +Q_ASSERT(m_proc
kfunk added a reviewer: sitter.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8309
To: kfunk, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8309
AFFECTED FILES
src/aboutbugreportingdialog.h
src/backtracegener
