This revision was automatically updated to reflect the committed changes.
Closed by commit R871:c50470387510: Make Qt5::X11Extras really optional
(authored by kfunk).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8307?vs=20787&id=20804
REVISION DETAIL
http
rjvbb added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:32
> Is this change needed?
I don't understand, since when has DrKonqi been split out of plasma-runtime?
Plasma-runtime had a different approach: search for X11Extras only when X11 was
found. I think that's the better
sitter accepted this revision.
sitter added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:32
> Is this change needed?
Don't think this makes a difference. From a cmake POV the new version is more
correct though as Qt5 was already found so only finding Qt5X11Extras on its own
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:32
>
> -find_package(Qt5 ${QT_MIN_VERSION} CONFIG COMPONENTS X11Extras)
> +find_package(Qt5X11Extras ${QT_MIN_VERSION} CONFIG)
>
Is this change needed?
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabrica
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb, sitter, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute
kfunk added a reviewer: sitter.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk added a reviewer: rjvbb.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise may fail with:
CMake Warning at CMakeLists.txt:32 (find_package):
Found package configuration file:
/Users/kfunk/
