This revision was automatically updated to reflect the committed changes.
Closed by commit R119:06e2cf0d9771: Port away from PlasmaCore.Units in system
settings modules (authored by davidedmundson).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8286?vs
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8286
To: davidedmundson, #plasma, mart
Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
davidedmundson updated this revision to Diff 20891.
davidedmundson added a comment.
Change units to Units
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8286?vs=20712&id=20891
REVISION DETAIL
https://phabricator.kde.org/D8286
AFFECTED FILES
kcm
mart added inline comments.
INLINE COMMENTS
> apol wrote in main.qml:28
> Should be using `Units.gridUnit`, no?
this needs porting too, then good to go
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8286
To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel
apol added inline comments.
INLINE COMMENTS
> main.qml:28
> Item {
> implicitWidth: units.gridUnit * 20
> implicitHeight: units.gridUnit * 20
Should be using `Units.gridUnit`, no?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8286
To: davidedmundso
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As Kirigrami has it's own version.
We want to be moving towards not having any Plasma impo
