davidedmundson abandoned this revision.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8234
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in CategoriesPage.qml:35
> There's even an `anchors.fill: parent` below
oh you're right :/
I'll check if I can just kill this line.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8234
To: d
broulik added inline comments.
INLINE COMMENTS
> CategoriesPage.qml:35
> id: searchLayout
> -height: menuButton.height
> +implicitHeight: menuButton.implicitHeight
> spacing: Kirigami.Units.smallSpacing
There's even an `anchors.fill: parent` belo
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Setting a parent's height to a child's height in a layout never makes
sense as layouts will a