fvogt added a comment.
> If the only reason for settings QT_QUICK_CONTROLS_1_STYLE in startkde was
fixing the warning when QT_QUICK_CONTROLS_STYLE was set, I guess you can stop
setting it now
Yes it is (as mentioned in the various reviews and IRC)
However, it's probably a good idea
arojas added a comment.
In https://phabricator.kde.org/D7953#148962, @fvogt wrote:
> This is not as clear as it could be. What about just not setting
QT_QUICK_CONTROLS_1_STYLE in the first place?
> QT_QUICK_CONTROLS_1_STYLE is only necessary because of
QT_QUICK_CONTROLS_STYLE.
fvogt added a comment.
This is not as clear as it could be. What about just not setting
QT_QUICK_CONTROLS_1_STYLE in the first place?
QT_QUICK_CONTROLS_1_STYLE is only necessary because of
QT_QUICK_CONTROLS_STYLE.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:059369d6b6a9: Use QQuickStyle to set the QQC2 style
(authored by arojas).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7953?vs=1
davidedmundson added a comment.
We should definitely be strict about adding addititional dependencies after
the freeze, but I think in this case it's safe and worth it.
I shall send an email to kde-distro-packagers to make sure everyone knows.
REPOSITORY
R135 Integration for Qt applica
arojas added a comment.
so is this OK for 5.11?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7953
To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, a
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Soo much cleaner. Thanks for taking care of this
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7953
To: arojas,
arojas edited the test plan for this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7953
To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
arojas created this revision.
arojas added reviewers: davidedmundson, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use QQuickStyle::setStyle instead of an environment variable to set the QQC2
desktop style. Thi
