D7939: ColorSet concept in Theme

meven added inline comments. INLINE COMMENTS > ratijas wrote in platformtheme.h:223-224 > What was this TODO all about? I am guessing adding making `colorsChanged(Kirigami::PlatformTheme::ColorSet colorSet)`. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To:

D7939: ColorSet concept in Theme

ratijas added inline comments. INLINE COMMENTS > platformtheme.h:223-224 > +Q_SIGNALS: > +//TODO: parameters to signals as this is also a c++ api > +void colorsChanged(); > +void defaultFontChanged(const QFont &font); What was this TODO all about? REPOSITORY R169 Kirigami REVISIO

D7939: ColorSet concept in Theme

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5b08a7b6cd50: ColorSet concept in Theme (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7939?vs=20297&id=20298#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE ht

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20297. mart added a comment. - Merge branch 'master' into arcpatch-D7939 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20247&id=20297 BRANCH arcpatch-D7939 REVISION DETAIL https://phabricator.kde.org/D7939

D7939: ColorSet concept in Theme

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/colorcontext REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami, hein Cc: plasma-devel, apol, davidedmundson, mart, hein

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20247. mart added a comment. - finalize signatures for signals - todo on font change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20110&id=20247 BRANCH mart/colorcontext REVISION DETAIL https://phabricat

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20110. mart added a comment. - support for custom colors - support "color" property for icons REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20106&id=20110 BRANCH mart/colorcontext REVISION DETAIL https://

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20106. mart added a comment. - bind missing colors - add missing roles - complete colors definition for fallback qml themes - active coloring when pressed - Merge branch 'master' into mart/colorcontext - support static linking with included pri and q

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20006. mart added a comment. - remove binary file - give focus on press by default REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20005&id=20006 BRANCH mart/colorcontext REVISION DETAIL https://phabricator

D7939: ColorSet concept in Theme

mart updated this revision to Diff 20005. mart added a comment. - Merge branch 'master' into mart/colorcontext - add a rangeslider to the gallery - some comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=19797&id=20005 BRANCH mart/color

D7939: ColorSet concept in Theme

mart added a reviewer: hein. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami, hein Cc: plasma-devel, apol, mart, hein

D7939: ColorSet concept in Theme

mart added a comment. F3921580: Spectacle.F26086.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart Cc: plasma-devel, apol, mart, hein

D7939: ColorSet concept in Theme

mart added a reviewer: Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami Cc: plasma-devel, apol, mart, hein

D7939: ColorSet concept in Theme

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Theme is now an attached property rather than a singleton (in 2.2 import) a "colorSet" property can be defined on it and all its color propert