This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1783fda30eee: Make sure OpenGL Context is valid before
deleting shader (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7888?vs=19698&id=19
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Feel free to push either of the two revisions.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7888
To: davidedmundson, #plasma, graesslin
Cc:
davidedmundson updated this revision to Diff 19698.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
No done()
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7888?vs=19693&id=19698
BRANCH
master
REVISION D
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:1191-1194
> best would be if we knew that the context is current. But that's
> unfortunately wishful thinking.
>
> My suggestion would be to do your option 1:
>
> > makeOpenGLContextCurrent() but then d
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in scene_opengl.cpp:1191-1194
> changed is called from a timer, so we can be pretty confident that we're
> called mid-doing anything else, but I'm happy to do something else?
>
> to be clear are you suggesting we:
>
> - ma
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:1191-1194
> This combination also looks dangerous. If the context was already current it
> might disable it for another user inside KWin.
changed is called from a timer, so we can be pretty confident tha
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> scene_opengl.cpp:1191-1194
> +makeOpenGLContextCurrent();
> +delete m_lanczosFilter;
> +m_lanczosFilter =
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Deleting the lanczos filter deletes it's GLShader, this calls
glDeleteProgram
g
