D7716: Support filepaths with accents

2017-11-13 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. See thread on https://phabricator.kde.org/D7732, it's not reliable to do this. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D7716 To: davidedmundson, #plasma Cc: apol, pl

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in sddmauthhelper.cpp:228 > in my case I need to change the locale of my helper, not just subprocesses, > which means I need to set it before I extract args from the user. Maybe it could still be done by `KAuth::HelperSupport::h

D7716: Support filepaths with accents

2017-09-07 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in sddmauthhelper.cpp:228 > I just realized we have something similar in samba-mounter for the exact same > reason: > https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49 > > In this case we're forwarding t

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:228 > +int main(int argc, char **argv) { > +qputenv("LANG", "C.UTF-8"); > +return KAuth::HelperSupport::helperMain(argc, argv, > "org.kde.kcontrol.kcmsddm", new SddmAuthHelper()); I just realized we have something similar

D7716: Support filepaths with accents

2017-09-06 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our helper runs as root and doesn't have the user's environment (including $LANG). This defaults to one without UTF-8. Without a